Refactor numbers to be generated by type - #55
Merged
Merged
Conversation
ThuF
requested changes
Mar 18, 2026
ThuF
left a comment
ThuF
left a comment
Contributor
There was a problem hiding this comment.
I guess the following functionality is not yet released?
new NumberGeneratorService().generateByType('XXX')Also I guess we should update the project.json file to include the latest version of the number generator module
Contributor
|
There are also merge conflicts that needs to be resolved before merging the PR |
ThuF
approved these changes
Apr 2, 2026
ThuF
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: