Skip to content

Can we allow gl_nearest_mipmap_* again? (r_texturemode, line 286) #1

Description

@Jrkbgrt

Hey Enzo,

first of all, thanks for 1.6.8, the ruleset stuff works really well. I'd like to ask about one rule from the CoDBase list though: blocky textures.

Line 286 in codbase-2023-05.pb says

pb_sv_cvar r_texturemode INCLUDE GL_LINEAR_MIPMAP_

so r_texturemode gl_nearest_mipmap_nearest gets reset to the default the moment you're on any server with a competitive.cfg. I know this isn't new, CoDBase has had it in their PB cvar list since 2020. But plenty of servers always allowed it, and now that the list is enforced everywhere it would be nice to reconsider it.

What I'd like to change (v4):

pb_sv_cvar r_texturemode INCLUDE GL_LINEAR_MIPMAP_ GL_NEAREST_MIPMAP_

Mipmaps stay required, so plain GL_NEAREST and GL_LINEAR stay banned like now. It just adds gl_nearest_mipmap_nearest and gl_nearest_mipmap_linear. I checked the parser, multiple INCLUDE values on one line work and it's case insensitive, so this line should just work.

Why I think it's fine to allow:

  • Nearest vs linear only changes how the pixels get blended, sharp edges or smooth. You don't see anything extra with it.
  • picmip 0-3 is already allowed, so low-res textures are fine by the rules. Nearest just keeps those big pixels sharp instead of blurry.
  • It was banned on some leagues and allowed on a lot of other servers, and nobody had a problem with it there. Now that the list is the standard for everyone, it's a good moment to look at whether the rule is still worth having.
  • Tricknades. That's a real cod1 thing and a big part of why people still play this game. A lot of those lineups were learned on blocky textures, and it's open to everyone, so nobody gains anything unfair from it. Allowing it just makes the game more interesting to play and to watch.

If CoDBase had an actual reason to ban the nearest modes back in 2020 (some map or shader where it shows something it shouldn't), I'd love to know, and then forget I asked :) I couldn't find anything written down, the list has no comment on that line.

Happy to do the PR if you want, and I can test v4 on our match server and tell you what cod1x_rs reports.

Cheers

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions