fix: preserve inverted gitignore traversal - #239
Merged
Conversation
Member
|
thanks a lot for the PR! @georgeh0 can help take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
Summary
Inverted
.gitignorefiles that start with*and reopen directories with!*/are pruned under pathspec 1.x, so source files below those directories never reach the matcher.uv.lockContent/exclusions remain excludedThe dependency bound is intentional:
GitIgnoreSpecin pathspec 1.0.4 and 1.1.1 marks the reopened directories ignored, while 0.12.1 matches Git for this pattern. Using plainPathSpecis not equivalent because it changes file-ignore behavior.Testing
uv run pytest tests/test_file_walk.py -vuv run mypy src/ tests/uv run prek run --all-files --verbose --show-diff-on-failure --skip pytestuv run pytest tests/ -v(270 passed, 8 deselected)