drpcstream: optimize sendWindow#81
Open
shubhamdhama wants to merge 1 commit into
Open
Conversation
sendWindow has a single acquirer and a single granter, so serializing every credit update behind a mutex adds avoidable contention. Debit credit atomically before waiting and represent a pending acquisition as a negative balance. Grants can then update the balance atomically and wake the acquirer only when the deficit is repaid. acquire no longer accepts a context, so it does not need channel-based notifications. Replace the channel with a lazily allocated condition variable, keeping the mutex only around waiting and signaling to prevent lost wakeups. The stream checks termination before acquiring credit, so the fast path does not need a separate closed check. The close error now acts as the terminal marker and is consulted only when an acquisition blocks. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for putting this up! Two comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendWindow has a single acquirer and a single granter, so serializing every credit update behind a mutex adds avoidable contention. Debit credit atomically before waiting and represent a pending acquisition as a negative balance. Grants can then update the balance atomically and wake the acquirer only when the deficit is repaid.
acquire no longer accepts a context, so it does not need channel-based notifications. Replace the channel with a lazily allocated condition variable, keeping the mutex only around waiting and signaling to prevent lost wakeups.
The stream checks termination before acquiring credit, so the fast path does not need a separate closed check. The close error now acts as the terminal marker and is consulted only when an acquisition blocks.