Skip to content

cdi: add resolved edits API - #322

Open
ebendler wants to merge 1 commit into
cncf-tags:mainfrom
ebendler:edits_api
Open

cdi: add resolved edits API#322
ebendler wants to merge 1 commit into
cncf-tags:mainfrom
ebendler:edits_api

Conversation

@ebendler

Copy link
Copy Markdown

The idea here is that some CDI consumers may not be operating on an OCI container (think sandbox wrappers), but it would be silly to have them all re-implement the code that maps the specfile to the running host when the reference implementations are already doing all of that work.

See also: cncf-tags/container-device-interface-rs#101

@zvonkok
zvonkok requested review from Copilot and klihub and removed request for klihub July 15, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread pkg/cdi/resolved-edits.go Outdated
Comment thread pkg/cdi/resolved-edits.go Outdated
@ebendler

Copy link
Copy Markdown
Author

Thanks, @klihub — your comments made the result API clearer. I’ve updated the resolved device-node and mount outputs to embed the effective CDI types with scope metadata, and added coverage for the FIFO zero-value convention.

Comment thread pkg/cdi/resolved-edits.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread pkg/cdi/cache.go
Comment thread pkg/cdi/cache.go
Comment thread pkg/cdi/cache.go Outdated
Comment thread pkg/cdi/cache.go Outdated
Signed-off-by: Ehren Bendler <ebendler@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants