Skip to content

Wire 2024/2025 corrections and weight_base_cmb - #125

Merged
kandrosov merged 18 commits into
cms-flaf:mainfrom
kandrosov:prepare-run3-2025
Aug 14, 2026
Merged

Wire 2024/2025 corrections and weight_base_cmb#125
kandrosov merged 18 commits into
cms-flaf:mainfrom
kandrosov:prepare-run3-2025

Conversation

@kandrosov

Copy link
Copy Markdown
Contributor

Summary

Corrections for Run3_2024 / Run3_2025 (Summer24 NanoAODv15):

  • PU: 2025 golden JSON + Summer24 69.2 mb weights
  • Tau: 2025 TAU folder, VSjet wp_VSmu and VSmu extra args
  • Electron: 2025 EGM eleID; evaluate 2025 with 2024Prompt / 2025Prompt as required by the JSON
  • Jet: 2025 data JEC Winter25Prompt25_V3_DATA, run letters B–G
  • Fatjet: 2025 fallback
  • HLT: 2025 electron HLT falls back to the 2024 EGM file; local CrossEleTau JSONs still use 2023PromptD
  • Recoil: 2025 reuses the 2024 JSON
  • weight_base_cmb written at AnaTupleMerge
  • A correction whose modes.<stage> is none is not applied at that stage

Testing

Exercised through the analysis HistPlot chains on Run3_2024 and Run3_2025 for HH_bbtautau, HH_bbWW and H_mumu (--test 1000, TestModel).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires up Monte Carlo corrections for the new Run3_2024 / Run3_2025 data-taking periods (Summer24 NanoAODv15), plus 2026_Summer24 placeholders, across the correction modules (PU, tau, electron, jet, fatjet, HLT, recoil, jet-veto, muon). It also adds a combined normalisation weight (weight_base_cmb) computed at the AnaTupleMerge stage using FLAF's shared_mc helpers, so shared-MC samples can be reweighted against an in-era denominator. This extends the framework's period-dependent correction plumbing without altering existing Run2/2022/2023 behavior.

Changes:

  • Add 2024/2025 (and 2026 placeholder) period entries and JSON/tag mappings across all correction modules, including new year-specific correctionlib evaluate signatures for tau VSjet/VSmu and a refactored electron_id_sf_year helper (with a new unit test).
  • Add electron/HLT/recoil/fatjet fallbacks where dedicated 2025/2026 JSONs are not yet published, and expand 2025 jet run letters (B–G) while dropping the per-era Run{} JEC data tag.
  • Add weight_base_cmb computation in Corrections.py driven by shared_mc, including a new 2026 golden JSON data file and PU 69.2 mb weight wiring.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
triggersRun3.py Adds ele_year/cross_ele_year, _json_trg_key fallback helper, and EGM/HLT year selection for 2025/2026
triggersRun3.h Extends supported-era gate to include 2026_Summer24
tau.py Adds 2024/2025/2026 tau JSON era keys and per-period SF-source filtering
tau.h Year-specific evaluate argument lists for VSjet (2025) and VSmu (2024/2025)
electron.py Extracts electron_id_sf_year helper; wires 2025/2026 eleID
test_electron_id_sf_year.py New unit test extracting and exercising electron_id_sf_year in isolation
pu.py Adds golden-JSON keys and a PU file-suffix map for 2025/2026
mu.py Adds 2026_Summer24 placeholder source lists
jet.py Adds 2026 tags, expands 2025 run letters (B–G), removes per-era Run{} data tag
fatjet.py Adds 2024/2025/2026 AK8 SF fallbacks to the 2023postBPix file
JetVetoMap.py Adds 2026 veto-map placeholder
bosonicRecoil.py Reuses 2024 recoil JSON for 2025/2026
CorrectionsCore.py Adds 2026 POG folder entries and fills 2025 LUM/TAU paths
Corrections.py Adds weight_base_cmb / shared_mc in-era denominator logic
data/golden_json/Cert_Collisions2026_401624_403937_Golden.json New 2026 certified-lumi JSON

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread triggersRun3.py
@kandrosov

Copy link
Copy Markdown
Contributor Author

tested with cms-flaf/FLAF#300

@kandrosov
kandrosov merged commit e218045 into cms-flaf:main Aug 14, 2026
3 checks passed
@kandrosov
kandrosov deleted the prepare-run3-2025 branch August 14, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants