Define stitching processor variables before xs/denominator (FLAF #169) - #124
Merged
Merged
Conversation
This was referenced Aug 5, 2026
…sent at histogram stage (getNormalisationCorrections runs there too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to cms-flaf/FLAF#289 (dataset stitching, #169).
MCStitchersubclasses that select on a derived gen-level column (TT decay mode, LHEdilepton flavor/mass, Z→ττ filter) crash at the anaTuple stage:
getNormalisationCorrectionsbuilds the cross-section / denominator expressions without first defining those columns. The
built-in DY Vpt/NpNLO stitch only worked because
LHE_Vpt/LHE_NpNLOare native branches.Adds
prepareStitchingVariables(), which calls each stitching processor'sonAnaTuple_prepareDataFrameonce before the xs/denominator loop. Verified by real anaTupleruns of the new TT and DY→ττ stitchers (
weight_xsnow defines correctly and the event loopcompletes). Merge together with the FLAF PR.