Skip to content

Add a script to check solutions.#1691

Merged
veluca93 merged 1 commit intocms-dev:mainfrom
veluca93:solution-checker
May 2, 2026
Merged

Add a script to check solutions.#1691
veluca93 merged 1 commit intocms-dev:mainfrom
veluca93:solution-checker

Conversation

@veluca93
Copy link
Copy Markdown
Contributor

@veluca93 veluca93 commented May 2, 2026

No description provided.

@veluca93 veluca93 requested a review from Virv12 May 2, 2026 08:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

❌ Patch coverage is 0% with 142 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.88%. Comparing base (cf3b15b) to head (e12a717).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmscontrib/SolutionChecker.py 0.00% 142 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
- Coverage   54.16%   53.88%   -0.29%     
==========================================
  Files         340      341       +1     
  Lines       27835    27977     +142     
==========================================
- Hits        15077    15075       -2     
- Misses      12758    12902     +144     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 53.88% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread cmscontrib/SolutionChecker.py Outdated
@prandla
Copy link
Copy Markdown
Member

prandla commented May 2, 2026

Does this not run into #1483 ?

on a somewhat related note, filename_to_language is the only part of cms that is actually imported. this script might be more useful if this dependency were removed; then using it would not require a (local) cms installation at all.

@veluca93
Copy link
Copy Markdown
Contributor Author

veluca93 commented May 2, 2026

Does this not run into #1483 ?

on a somewhat related note, filename_to_language is the only part of cms that is actually imported. this script might be more useful if this dependency were removed; then using it would not require a (local) cms installation at all.

Probably yes.

@veluca93 veluca93 force-pushed the solution-checker branch from bf66b42 to 644933d Compare May 2, 2026 11:14
@veluca93
Copy link
Copy Markdown
Contributor Author

veluca93 commented May 2, 2026

Does this not run into #1483 ?
on a somewhat related note, filename_to_language is the only part of cms that is actually imported. this script might be more useful if this dependency were removed; then using it would not require a (local) cms installation at all.

Probably yes.

Now it does not anymore, and checks for slow testcases. PTAL.

Comment thread cmscontrib/SolutionChecker.py Outdated
Comment thread cmscontrib/SolutionChecker.py Outdated
@veluca93 veluca93 force-pushed the solution-checker branch from 644933d to a84c587 Compare May 2, 2026 13:59
@veluca93 veluca93 force-pushed the solution-checker branch from a84c587 to e12a717 Compare May 2, 2026 14:51
@veluca93 veluca93 merged commit 6a28840 into cms-dev:main May 2, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants