Integrate general partial modifier editor - #149
Open
oheartone wants to merge 1 commit into
Open
Conversation
Collaborator
|
Is there a general reason all of these need to be one big pull request? Could we separate out these changes into smaller ones (for example making modifier spacing its own PR), so that it's a bit easier to manage and keep track of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-integrates the previous general partial modifier work on top of the latest
mainbranch without overwriting the new PHASE_MOD-specific editor.Main changes:
GeneralPartialModifierDialogfor non-PHASE_MOD partial modifier editing.PartialModifierDialogas the specialized PHASE_MOD editor.PHASE_MOD + PARTIALto the specialized editor, and other non-DETUNE PARTIAL modifiers to the general editor.PHASE_MODas backend type7while allowing it to appear earlier in the UI through combo-box item data/display-order mapping.Partial Result String.Notes
I intentionally did not migrate the old
maxPartialCountForCurrentBottom()helper from my earlier branch. The current main branch already has spectrum partial-count logic used by the PHASE_MOD editor, and the general partial editor now reuses that same path. Keeping one shared path avoids conflicting partial-count behavior.