lass, partial: defer placeholder spatialization fan-out to end - #103
Open
passyur wants to merge 2 commits into
Open
lass, partial: defer placeholder spatialization fan-out to end#103passyur wants to merge 2 commits into
passyur wants to merge 2 commits into
Conversation
for each note, every partial was being expanded into `numChannels` full-length buffers during `spatialize_Track`. for the default spatializer, each of those buffers were identical copies scaled by `1/numChannels`. this change leverages the fact that these buffers are copies of an initial buffer by performing the per-partial spatialization computation outside of the per-sound loop (and during the unification step)
instead of repeatedly allocating new vectors, store vectors as members for each Reverb computation and reuse existing vectors (after zeroing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for each note, every partial was being expanded into
numChannelsfull-length buffers duringspatialize_Track. for the default spatializer, each of those buffers were identical copies scaled by1/numChannels. this change leverages the fact that these buffers are copies of an initial buffer by performing the per-partial spatialization computation outside of the per-sound loop (and during the unification step).