Migrate from Qt5 to Qt6 - #10
Open
mchamberland wants to merge 2 commits into
Open
Conversation
Replace removed Qt5 APIs so the project builds cleanly with Qt 6 widgets and charts. Co-authored-by: Cursor <cursoragent@cursor.com>
Use applicationDirPath() directly now that app bundles are disabled, and fail the build on pre-Qt6 deprecated APIs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QRegExp/QRegExpValidator,QString::SkipEmptyParts,QSignalMapper::mapped, mouse/wheel event helpers,QString/char/intconversions, font weights).../eb_guiexecutable, and refresh the README install notes.gui_locationwith the non-bundle layout by removing the old.app/Contents/MacOSupward path adjustment.QT_DISABLE_DEPRECATED_BEFORE=0x060000so remaining pre-Qt6 deprecated APIs fail at compile time.Test plan
cd source && qmake6 && make../eb_guilinks against Qt 6 frameworks/libraries and launchesconfiguration.txt,database/MAR_defaults.txt, anddatabase/metric_defaults.txtare found relative to the executable directory (not via a.apppath traversal)qmake6(not Qt5qmake) is used