Skip to content

fix(devops): recognize text-encoded UUIDs as strings - #996

Open
gargsajal9 wants to merge 1 commit into
cloudwego:mainfrom
gargsajal9:gargsajal9-recognize-uuid-string
Open

gargsajal9 wants to merge 1 commit into
cloudwego:mainfrom
gargsajal9:gargsajal9-recognize-uuid-string

Conversation

@gargsajal9

Copy link
Copy Markdown

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: (optional scope):
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

This is a transparent compatibility fix; the Devops English and Chinese README guidance is updated in this PR, so no separate user-docs PR is required.

(Optional) Translate the PR title into Chinese.

fix(devops): 将文本编码的 UUID 识别为字符串

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • Recognize Go types with compatible encoding.TextMarshaler and encoding.TextUnmarshaler implementations as JSON strings in Eino Dev schemas.
  • Decode those types through encoding/json, preserving UUID validation, pointer/null behavior, nested collections, and registered interface envelopes.
  • Keep types with custom JSON codecs on their existing paths to avoid inferring an incorrect schema shape.
  • Add real github.com/google/uuid regression coverage for schemas and debug runs from both START and selected nodes, plus codec-boundary tests.

zh(optional):

  • 将兼容实现 encoding.TextMarshalerencoding.TextUnmarshaler 的 Go 类型识别为 Eino Dev Schema 中的 JSON 字符串。
  • 通过 encoding/json 解码这些类型,保留 UUID 校验、指针和 null 语义、嵌套集合以及已注册接口封装格式。
  • 自定义 JSON 编解码类型继续沿用原有逻辑,避免推断错误的 Schema 类型。

Validation:

  • Linux Go 1.25.6: full Devops module tests with -race, cross-package coverage, and CI -gcflags="all=-l -N"
  • Focused UUID race tests
  • Repository-configured golangci-lint on changed lines
  • go vet, gofmt, license headers, and typos v1.42.3

(Optional) Which issue(s) this PR fixes:

Fixes #955

(optional) The PR that updates user documentation:

N/A — the Devops module READMEs are updated in this PR.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CLAassistant

CLAassistant commented Sep 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gargsajal9
gargsajal9 marked this pull request as ready for review September 10, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Recognize UUID as a string type

2 participants