Skip to content

refactor(chatwitheino): refactor generic APIs#232

Open
YellowDusk04 wants to merge 5 commits into
cloudwego:mainfrom
YellowDusk04:chore/chatwitheino-refactor
Open

refactor(chatwitheino): refactor generic APIs#232
YellowDusk04 wants to merge 5 commits into
cloudwego:mainfrom
YellowDusk04:chore/chatwitheino-refactor

Conversation

@YellowDusk04
Copy link
Copy Markdown

What type of PR is this?
chore
Check the PR title.

  • This PR title match the format: (optional scope):
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. (Optional) Translate the PR title into Chinese.
    chore(chatwitheino): 优化代码和文档
    (Optional) More detailed description for this PR(en: English/zh: Chinese).
    en: Update dependencies, optimize code quality, and improve documentation for chatwitheino example.

zh:

  • 依赖更新 :升级 volcengine-go-sdk,将 openai-go 改为直接依赖
  • 代码优化 :简化泛型类型参数、使用 strings.SplitSeq 和 maps.Copy 提升性能、 strings.Builder 替代字符串拼接
  • 文档更新 :更新 ch05 中间件接口文档,修复 ch06 链接格式,修正 ch07 中 isTarget 参数说明

Dependencies:
- adapt to simplified generic type parameters
- upgrade volcengine-go-sdk to v1.2.28
- promote openai-go/v3 to direct dependency

Code refactoring:
- simplify generic type parameters across all Typed/GraphTool APIs
- replace strings.Split with strings.SplitSeq for iterator efficiency
- use maps.Copy instead of manual map iteration
- use strings.Builder instead of string concatenation
- mark unused ctx parameters with underscore

Documentation:
- update TypedChatModelAgentMiddleware interface in ch05_middleware.md
- fix markdown link format in ch06_callback.md
- clarify isTarget parameter in ch07_interrupt_resume.md (explain ResumeWithParams vs Resume)
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 23, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants