Conversation
1134c0b to
97c2123
Compare
3d32913 to
f7be2fe
Compare
4ac8c67 to
d4c397a
Compare
a1cf745 to
ffb34d1
Compare
| Version int `json:"version"` | ||
| ReversePTR *string `json:"reverse_ptr"` | ||
| } | ||
| type RouterInterface struct { |
There was a problem hiding this comment.
As there will be a interface API at some point in the not so far future, is going for RouterInterface the right direction? I assumed we would use a generic Interface Type.
There was a problem hiding this comment.
I initially wanted to use interface but we have already an interface type (and, accordingly, an Address type):
Lines 68 to 81 in b10972e
The question I guess is, what do we do. We can e.g. rename the existing Interface to ServerInterface or LegacyInterface because we plan to unify them, and we'll need a new major version anyway due to #91, or we find another name.
Your opinon?
There was a problem hiding this comment.
As discussed, keep RouterInterface as submitted. On the server, rename the Interface to ServerInterface. This will be a breaking change, but it keeps the naming consistent.
No description provided.