Skip to content

feat(ui): uxdocs – update datagrid status and boolean recommendations - #2089

Merged
franzheidl merged 2 commits into
mainfrom
franz-uxdocs-update-datagrid-status-2088
Oct 15, 2026
Merged

franzheidl merged 2 commits into
mainfrom
franz-uxdocs-update-datagrid-status-2088

Conversation

@franzheidl

@franzheidl franzheidl commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Update the recommendation as to how to display boolean or one-of-a-restricted-set (mostly status-related) values to be less ambiguous, use plain text as a default, and point out trade-offs of using Badge or Pill.

This aims predominantly at preventing AI tooling form making an arbitrary choice when generating DataGrids, thus make generated output more consistent.

Related Issues

Closes #2088

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

- update the recommendation to be less ambiguoues, and use plain text as a default

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl franzheidl self-assigned this Oct 15, 2026
@franzheidl franzheidl added the documentation Improvements or additions to documentation label Oct 15, 2026
@franzheidl
franzheidl marked this pull request as ready for review October 15, 2026 09:29
@franzheidl
franzheidl requested a review from a team as a code owner October 15, 2026 09:29
Copilot AI balanced review requested due to automatic review settings October 15, 2026 09:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Non-boolean status values still lack the plain-text default central to the PR’s stated goal.

1 open finding

🧠 Review effort: Balanced

Comment thread docs/ux/datagrid.md Outdated
…estricted set

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@changeset-bot

changeset-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3f9c66c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation resolves the prior feedback and has no identified blocking issues.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@franzheidl
franzheidl merged commit b46c179 into main Oct 15, 2026
25 checks passed
@franzheidl
franzheidl deleted the franz-uxdocs-update-datagrid-status-2088 branch October 15, 2026 09:51
@github-project-automation github-project-automation Bot moved this from New to Done in Juno Roadmap Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-15 09:52 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Task](context): ux docs – declare plain text the default status for DataGrid items

5 participants