Skip to content

feat(ci): add Intent skill validation + drift review for ui-components - #2087

Draft
ArtieReus wants to merge 4 commits into
mainfrom
arite-test-intent-ci
Draft

ArtieReus wants to merge 4 commits into
mainfrom
arite-test-intent-ci

Conversation

@ArtieReus

Copy link
Copy Markdown
Collaborator

Summary

Changes Made

  • Change 1
  • Change 2
  • Change 3

Related Issues

  • Issue 1: [link to issue]

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 14:39
@ArtieReus
ArtieReus requested review from a team and franzheidl as code owners October 14, 2026 14:39
@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d71f75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

🚀 View preview at
https://cloudoperators.github.io/juno/pr-preview/pr-2087/

Built to branch gh-pages at 2026-10-14 15:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The frozen lockfile is inconsistent with package manifests, and several skill examples contain behavioral or accessibility defects.

19 open findings
What changed in this PR

Adds Intent-based developer guidance for ui-components, publishes the skills, and introduces CI validation with drift review.

Changes:

  • Adds 12 component and UX skill domains with supporting references.
  • Adds Intent metadata, dependency, and package publishing configuration.
  • Adds PR-time validation and source-drift review workflow.
File Description
.github/​workflows/​check-skills.yml Adds skill validation and drift review CI.
pnpm-lock.yaml Locks Intent and related dependency changes.
packages/​ui-components/​package.json Publishes skills and adds Intent tooling.
_artifacts/​skill_spec.md Records skill scope and decisions.
_artifacts/​domain_map.yaml Maps skills to domains, tasks, and components.
packages/​ui-components/​skills/​accessibility/​SKILL.md Adds accessibility guidance.
packages/​ui-components/​skills/​accessibility/​references/​announcing-dynamic-content.md Documents live-region patterns.
packages/​ui-components/​skills/​accessibility/​references/​semantic-foundations.md Documents semantic structure.
packages/​ui-components/​skills/​actions/​SKILL.md Adds action and button guidance.
packages/​ui-components/​skills/​actions/​references/​label-wording.md Documents action-label conventions.
packages/​ui-components/​skills/​actions/​references/​page-level-actions.md Documents toolbar action placement.
packages/​ui-components/​skills/​app-foundations/​SKILL.md Adds provider and theme setup guidance.
packages/​ui-components/​skills/​app-foundations/​references/​portals.md Documents portal usage.
packages/​ui-components/​skills/​app-foundations/​references/​providers-standalone.md Documents advanced provider setups.
packages/​ui-components/​skills/​data-display/​SKILL.md Adds content-display component guidance.
packages/​ui-components/​skills/​data-display/​references/​codeblock-footer.md Documents CodeBlock footer actions.
packages/​ui-components/​skills/​data-display/​references/​description-list-layout.md Documents DescriptionList layouts.
packages/​ui-components/​skills/​data-display/​references/​icon-names.md Documents icons and accessibility.
packages/​ui-components/​skills/​datagrid/​SKILL.md Adds DataGrid composition guidance.
packages/​ui-components/​skills/​datagrid/​references/​bulk-selection.md Documents bulk-selection state.
packages/​ui-components/​skills/​datagrid/​references/​toolbar-zones.md Documents DataGrid toolbar zones.
packages/​ui-components/​skills/​feedback/​SKILL.md Adds feedback-component guidance.
packages/​ui-components/​skills/​feedback/​references/​notifications.md Documents notification behavior.
packages/​ui-components/​skills/​feedback/​references/​semantic-variants.md Documents semantic variants.
packages/​ui-components/​skills/​forms/​SKILL.md Adds form composition guidance.
packages/​ui-components/​skills/​forms/​references/​secret-and-date.md Documents secret and date fields.
packages/​ui-components/​skills/​forms/​references/​selects.md Documents select components.
packages/​ui-components/​skills/​forms/​references/​sign-in.md Documents sign-in forms.
packages/​ui-components/​skills/​forms/​references/​validation.md Documents validation lifecycle.
packages/​ui-components/​skills/​interaction-patterns/​SKILL.md Adds interaction-flow guidance.
packages/​ui-components/​skills/​interaction-patterns/​references/​authorization-ui.md Documents authorization UI choices.
packages/​ui-components/​skills/​interaction-patterns/​references/​inline-crud.md Documents inline CRUD patterns.
packages/​ui-components/​skills/​interaction-patterns/​references/​wizard.md Documents wizard composition.
packages/​ui-components/​skills/​layout/​SKILL.md Adds application layout guidance.
packages/​ui-components/​skills/​layout/​references/​box-patterns.md Documents Box patterns.
packages/​ui-components/​skills/​layout/​references/​grid-and-stack.md Compares Grid and Stack.
packages/​ui-components/​skills/​layout/​references/​manual-layout.md Documents manual shell layout.
packages/​ui-components/​skills/​layout/​references/​page-footer.md Documents footer structure.
packages/​ui-components/​skills/​navigation/​SKILL.md Adds navigation guidance.
packages/​ui-components/​skills/​navigation/​references/​legacy-tabs.md Documents deprecated tab APIs.
packages/​ui-components/​skills/​navigation/​references/​pagination.md Documents pagination variants.
packages/​ui-components/​skills/​navigation/​references/​second-level-bars.md Compares horizontal navigation options.
packages/​ui-components/​skills/​overlays/​SKILL.md Adds overlay component guidance.
packages/​ui-components/​skills/​overlays/​references/​modal-patterns.md Documents modal patterns.
packages/​ui-components/​skills/​overlays/​references/​popup-menu-composition.md Documents PopupMenu composition.
packages/​ui-components/​skills/​overlays/​references/​tooltip-modes.md Documents tooltip modes.
packages/​ui-components/​skills/​ux-writing/​SKILL.md Adds UX-writing guidance.
packages/​ui-components/​skills/​ux-writing/​references/​empty-values.md Documents missing-value conventions.
packages/​ui-components/​skills/​ux-writing/​references/​title-case.md Documents title-case rules.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/ui-components/package.json
Comment thread packages/ui-components/skills/actions/SKILL.md
Comment thread packages/ui-components/skills/data-display/SKILL.md
Comment thread packages/ui-components/skills/datagrid/SKILL.md
Comment thread _artifacts/skill_spec.md
Comment thread packages/ui-components/skills/forms/SKILL.md
Comment thread packages/ui-components/skills/forms/references/validation.md
Comment thread packages/ui-components/skills/ux-writing/SKILL.md
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus
ArtieReus marked this pull request as draft October 15, 2026 08:04
@ArtieReus ArtieReus self-assigned this Oct 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants