Repository navigation
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
There was a problem hiding this comment.
🟡 Changes recommended
The frozen lockfile is inconsistent with package manifests, and several skill examples contain behavioral or accessibility defects.
19 open findings
Add a changeset for the published Intent skills · New Document that progress does not disable Button · New Add a human-readable title to the interactive icon · New Add a title to the interactive footer icon · New Make clickable rows keyboard-operable or use a link · New Preserve hidden selections when filtering visible rows · New Add an accessible label to the text input · New Reset busy and show errors when token revocation fails · New Make the disabled-control explanation keyboard accessible · New Handle cluster creation failures and reset busy state · New Add an accessible title to the icon-only button · New Use a focusable TooltipTrigger instead of a plain Icon · New Use the default button trigger for keyboard accessibility · New Use a focusable TooltipTrigger instead of an Icon · New Correct the record about Label being exported · New Correct the inaccurate closed shadow root styling guidance · New Use “Sign in” casing in the form example · New Remove “Please” from the user-facing error copy · New Correct title-case guidance for “There was an Error” · New
What changed in this PR
Adds Intent-based developer guidance for ui-components, publishes the skills, and introduces CI validation with drift review.
Changes:
- Adds 12 component and UX skill domains with supporting references.
- Adds Intent metadata, dependency, and package publishing configuration.
- Adds PR-time validation and source-drift review workflow.
| File | Description |
|---|---|
.github/workflows/check-skills.yml |
Adds skill validation and drift review CI. |
pnpm-lock.yaml |
Locks Intent and related dependency changes. |
packages/ui-components/package.json |
Publishes skills and adds Intent tooling. |
_artifacts/skill_spec.md |
Records skill scope and decisions. |
_artifacts/domain_map.yaml |
Maps skills to domains, tasks, and components. |
packages/ui-components/skills/accessibility/SKILL.md |
Adds accessibility guidance. |
packages/ui-components/skills/accessibility/references/announcing-dynamic-content.md |
Documents live-region patterns. |
packages/ui-components/skills/accessibility/references/semantic-foundations.md |
Documents semantic structure. |
packages/ui-components/skills/actions/SKILL.md |
Adds action and button guidance. |
packages/ui-components/skills/actions/references/label-wording.md |
Documents action-label conventions. |
packages/ui-components/skills/actions/references/page-level-actions.md |
Documents toolbar action placement. |
packages/ui-components/skills/app-foundations/SKILL.md |
Adds provider and theme setup guidance. |
packages/ui-components/skills/app-foundations/references/portals.md |
Documents portal usage. |
packages/ui-components/skills/app-foundations/references/providers-standalone.md |
Documents advanced provider setups. |
packages/ui-components/skills/data-display/SKILL.md |
Adds content-display component guidance. |
packages/ui-components/skills/data-display/references/codeblock-footer.md |
Documents CodeBlock footer actions. |
packages/ui-components/skills/data-display/references/description-list-layout.md |
Documents DescriptionList layouts. |
packages/ui-components/skills/data-display/references/icon-names.md |
Documents icons and accessibility. |
packages/ui-components/skills/datagrid/SKILL.md |
Adds DataGrid composition guidance. |
packages/ui-components/skills/datagrid/references/bulk-selection.md |
Documents bulk-selection state. |
packages/ui-components/skills/datagrid/references/toolbar-zones.md |
Documents DataGrid toolbar zones. |
packages/ui-components/skills/feedback/SKILL.md |
Adds feedback-component guidance. |
packages/ui-components/skills/feedback/references/notifications.md |
Documents notification behavior. |
packages/ui-components/skills/feedback/references/semantic-variants.md |
Documents semantic variants. |
packages/ui-components/skills/forms/SKILL.md |
Adds form composition guidance. |
packages/ui-components/skills/forms/references/secret-and-date.md |
Documents secret and date fields. |
packages/ui-components/skills/forms/references/selects.md |
Documents select components. |
packages/ui-components/skills/forms/references/sign-in.md |
Documents sign-in forms. |
packages/ui-components/skills/forms/references/validation.md |
Documents validation lifecycle. |
packages/ui-components/skills/interaction-patterns/SKILL.md |
Adds interaction-flow guidance. |
packages/ui-components/skills/interaction-patterns/references/authorization-ui.md |
Documents authorization UI choices. |
packages/ui-components/skills/interaction-patterns/references/inline-crud.md |
Documents inline CRUD patterns. |
packages/ui-components/skills/interaction-patterns/references/wizard.md |
Documents wizard composition. |
packages/ui-components/skills/layout/SKILL.md |
Adds application layout guidance. |
packages/ui-components/skills/layout/references/box-patterns.md |
Documents Box patterns. |
packages/ui-components/skills/layout/references/grid-and-stack.md |
Compares Grid and Stack. |
packages/ui-components/skills/layout/references/manual-layout.md |
Documents manual shell layout. |
packages/ui-components/skills/layout/references/page-footer.md |
Documents footer structure. |
packages/ui-components/skills/navigation/SKILL.md |
Adds navigation guidance. |
packages/ui-components/skills/navigation/references/legacy-tabs.md |
Documents deprecated tab APIs. |
packages/ui-components/skills/navigation/references/pagination.md |
Documents pagination variants. |
packages/ui-components/skills/navigation/references/second-level-bars.md |
Compares horizontal navigation options. |
packages/ui-components/skills/overlays/SKILL.md |
Adds overlay component guidance. |
packages/ui-components/skills/overlays/references/modal-patterns.md |
Documents modal patterns. |
packages/ui-components/skills/overlays/references/popup-menu-composition.md |
Documents PopupMenu composition. |
packages/ui-components/skills/overlays/references/tooltip-modes.md |
Documents tooltip modes. |
packages/ui-components/skills/ux-writing/SKILL.md |
Adds UX-writing guidance. |
packages/ui-components/skills/ux-writing/references/empty-values.md |
Documents missing-value conventions. |
packages/ui-components/skills/ux-writing/references/title-case.md |
Documents title-case rules. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>


Summary
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.