Repository navigation
feat(ui): add appearance="buttons" to TabBar and rename "main" to "tabs" #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cd55ebe
feat(ui): add TabBar appearance="buttons", rename "content" to "tabs"…
MartinS-git f2151ff
feat(ui): rename appearance="main" to "tabs", keep "content" as disti…
MartinS-git 70b0bff
refactor(ui): rename warnedDeprecatedContent ref to warnedDeprecatedMain
MartinS-git 14d9200
fix(ui): prevent hover style on disabled TabBar button items
MartinS-git 057f180
fix(ui): address TabBar review feedback
MartinS-git d65358f
style(ui): apply prettier formatting to TabBarItem
MartinS-git 7ba43e5
test(ui): remove redundant deprecated main appearance test in TabBar
MartinS-git e696c14
Merge branch 'main' into tabBar-appearance
MartinS-git 884a115
refactor(ui): replace arbitrary Tailwind values with standard utiliti…
MartinS-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| "@cloudoperators/juno-ui-components": minor | ||
| --- | ||
|
|
||
| feat(ui): add TabBar `appearance="buttons"` and rename `appearance="main"` to `appearance="tabs"` | ||
|
|
||
| - Add `appearance="buttons"` to `TabBar` for a pill-style segmented control, useful for pre-defined filters. | ||
| - Rename `appearance="main"` to `appearance="tabs"`. `appearance="tabs"` is now the default. | ||
| - `appearance="main"` keeps working as a deprecated alias and emits a deprecation warning. Switch to `appearance="tabs"`. | ||
| - `appearance="content"` remains a distinct style variant with a shared bottom border (unchanged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.