Refactor: Use DesignInterface for Hyvä Theme Detection in ProductGalleryHelper#135
Open
itaymesh wants to merge 638 commits intocloudinary:masterfrom
Open
Refactor: Use DesignInterface for Hyvä Theme Detection in ProductGalleryHelper#135itaymesh wants to merge 638 commits intocloudinary:masterfrom
itaymesh wants to merge 638 commits intocloudinary:masterfrom
Conversation
added 30 commits
March 1, 2021 17:27
…h on BatchUploader
…rder to improve support for spaces and other special chars
v1.14.8: minor fix
v1.14.8: minor fix
v1.14.9: Fixed an issue on BulkUpload
…e-cloudinary into v1.20.3a
…reselect first thumb and pushing the new swatches to the start of thumbs
…ed Cloudinary plugins
arielashri
approved these changes
Mar 23, 2025
arielashri
approved these changes
Mar 23, 2025
RonenGiritCloudinary
force-pushed
the
master
branch
from
317f0fd to
2ec9f57
Compare
RonenGiritCloudinary
force-pushed
the
master
branch
from
2ec9f57 to
d5e8519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Overview
This PR updates the
ProductGalleryHelper::isHyvaThemeEnabled()method to useDesignInterfaceinstead ofThemeProvider, ensuring accurate detection of Hyvä-based themes, including child themes.Changes:
ThemeProviderwithDesignInterfaceto align with\Hyva\Theme\Service\CurrentTheme::isHyva().isHyvaThemeEnabled()to check parent themes recursively for better Hyvä theme detection.DesignInterfacevia constructor to follow Magento's best practices.Why This Change?
ThemeProviderandScopeConfigInterfacefor theme resolution.Notes:
This change does not affect existing functionality beyond improving Hyvä theme detection.
No other parts of the class were refactored to maintain scope.