fix: use lowercase units for clock drift metrics - #329
Open
ay901246 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
ay901246
force-pushed
the
clock-drift-monitoring
branch
from
July 27, 2026 22:23
3339c7d to
ad27eeb
Compare
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
jorbaum
approved these changes
Jul 29, 2026
jorbaum
left a comment
jorbaum
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Sensible and straight forward fix.
AFAICS strictly speaking this would be a breaking change now as we have released your newly added clock drift feature in v3.0.29. I do not think we need to be strict here though.
Side-note: At some point it might make sense to release a new minor-release (i.e. 3.1.X) as we have added some new features over the last few weeks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loggregator automatically appends the unit tag to the metric name. Using
Secondsresulted in awkward metric names likeclock_drift_system_time_offset_seconds_Seconds. This changes the units to lowercase (seconds,ppm,stratum) so they match the standard Loggregator emission format.Made with Cursor