add error message in applog-stream for syslog-drain validation#723
Merged
chombium merged 2 commits intoJul 10, 2026
Merged
Conversation
- improve and optimize code
10 tasks
chombium
approved these changes
Jul 10, 2026
chombium
left a comment
Contributor
There was a problem hiding this comment.
@corporatemax Thank you very much for your contribution and the cooperation 🥳
This was referenced Jul 10, 2026
jorbaum
added a commit
to jorbaum/cf-k8s-releases
that referenced
this pull request
Jul 13, 2026
c0d1ngm0nk3y
pushed a commit
to cloudfoundry/cf-k8s-releases
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change moves the Syslog Drain URL validation from the Syslog Agent to the Syslog Binding Cache in order to lower down the log volume produced when there are invalid drains. The Syslog Agent is practically deployed on every VM in a foundation and up until now when an app developer didn't configure properly a Syslog drain URL, each Syslog Agent did the validation on its own and has written a log reporting the error. Now, with the move of the validation to the Syslog Binding Cache which is deployed on the Scheduler VM, the previously mentioned log load is drastically reduced, as there is only one Scheduler VM per availability zone and that the Syslog Binding Cache is updated by default every minute. Up until now, the validation in the Syslog Agent was done by default every 15 seconds. This change lowers down the number of the logs written, as well as the time interval on which the logs are written.
On top of that, from now on, the application developers will get an error message each time when they configure an invalid Syslog Drain URL.
A part from the already present log messages about dropped logs due to unreachable destination, e.g.
now they also get notified about misconfigured Syslog Drain URL, e.g.
This change brings a lot of benefits, but also a small breaking change: As the Syslog Drain validation was moved from the Syslog Agent to the Syslog Binding Cache, the
invalid_drainsandblacklisted_drainsmetrics have been move to the Syslog Binding Cache as well.Note: As of now on, the Syslog Agent get only valid drain URLs and there is still Syslog Drain URL validation in the Syslog Agent to safeguard against tempered Syslog Binding Cache API. In case the validation in the Syslog Agent notices an invalid drain it will warn the operators through the logs that they have to check the Syslog Binding Cache.
Closes #579
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack