make compatibilityChecker robust if v2 api is disabled. dirty fix for #1229#1356
Open
Lokowandtg wants to merge 2 commits intocloudfoundry:mainfrom
Open
make compatibilityChecker robust if v2 api is disabled. dirty fix for #1229#1356Lokowandtg wants to merge 2 commits intocloudfoundry:mainfrom
Lokowandtg wants to merge 2 commits intocloudfoundry:mainfrom
Conversation
Contributor
|
Hey @Lokowandtg Questions:
|
Contributor
Author
|
Without this pull request, the CloudFoundryClientCompatibilityChecker runs into a NullPointerException when v2 API is not available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the compatibility checker does not fail if v2 API is not available.
In that case, no check is executed, which is not correct.
I will work on adding v3/info endpoint and checking that version next.