Skip to content

Label the bosh-deployment pipeline GCP resources - #535

Merged
ramonskie merged 1 commit into
developfrom
label-bosh-deployment-pipeline
Sep 25, 2026
Merged

ramonskie merged 1 commit into
developfrom
label-bosh-deployment-pipeline

Conversation

@ramonskie

Copy link
Copy Markdown
Contributor

Summary

First pipeline in the GCP cost-attribution rollout: label the GCP resources owned by the bosh-deployment pipeline with pipeline=bosh-deployment.

Both the director environment (created by bbl) and the workload deployment (nats) are labelled, so the pipeline's GCP spend can be attributed to it in billing.

Changes

File Change
ci/tasks/bbl-up-bosh-gcp.yml declare the BBL_GCP_LABELS task param (default empty)
ci/pipeline.yml set BBL_GCP_LABELS: pipeline=bosh-deployment on the bbl-up task of both test-noble-gcp and test-resolute-gcp
ci/tasks/test-gcp.sh apply misc/tags.yml to the nats deployment and pass deployment_tags

Dependencies

  • cloudfoundry/bosh-bootloader#694 — BBL_GCP_LABELS / --gcp-label, which makes bbl label the director VM, jumpbox VM and the terraform resources it manages.
    Note: this pipeline runs the bbl bundled in the cloudfoundry/cf-deployment-concourse-tasks image, so the labels only appear once that image ships a bbl release containing #694. Until then the env var is simply ignored.
  • cloudfoundry/bosh-deployment#534 — misc/tags.yml. Merge Add generic tags ops file #534 first, otherwise -o misc/tags.yml fails.

Verification

  • ci/pipeline.yml and the task YAML parse cleanly (python3 -c "yaml.safe_load(...)")
  • bash -n clean on test-gcp.sh and bbl-up-bosh-gcp.sh
  • bosh interpolate ci/assets/nats.yml -o tests/cred-test.yml -o misc/tags.yml -v stemcell_os=ubuntu-noble -v 'deployment_tags={"pipeline":"bosh-deployment"}' → tags: {pipeline: bosh-deployment} present

Notes

The GCP jobs destroy the environment in an ensure: bbl-down, so this pipeline is not long-lived. It validates the mechanism end-to-end before rolling out to persistent environments.

Pilot for GCP cost attribution.

- Declare the BBL_GCP_LABELS task param and set it to
  pipeline=bosh-deployment on the bbl-up task of the GCP jobs, so bbl labels
  the director and jumpbox VMs and the terraform resources it manages
  (cloudfoundry/bosh-bootloader#694).
- Apply misc/tags.yml to the nats deployment so the deployment VMs are
  labelled as well (#534).
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9d32da75-3309-4f95-96c1-74330291a997

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ramonskie
ramonskie merged commit 7f33938 into develop Sep 25, 2026
3 checks passed
@ramonskie
ramonskie deleted the label-bosh-deployment-pipeline branch September 25, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants