Repository navigation
Label the bosh-deployment pipeline GCP resources - #535
Merged
Merged
Conversation
Pilot for GCP cost attribution. - Declare the BBL_GCP_LABELS task param and set it to pipeline=bosh-deployment on the bbl-up task of the GCP jobs, so bbl labels the director and jumpbox VMs and the terraform resources it manages (cloudfoundry/bosh-bootloader#694). - Apply misc/tags.yml to the nats deployment so the deployment VMs are labelled as well (#534).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
benjaminguttmann-avtq
approved these changes
Sep 24, 2026
rkoster
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First pipeline in the GCP cost-attribution rollout: label the GCP resources owned by the
bosh-deploymentpipeline withpipeline=bosh-deployment.Both the director environment (created by
bbl) and the workload deployment (nats) are labelled, so the pipeline's GCP spend can be attributed to it in billing.Changes
ci/tasks/bbl-up-bosh-gcp.ymlBBL_GCP_LABELStask param (default empty)ci/pipeline.ymlBBL_GCP_LABELS: pipeline=bosh-deploymenton thebbl-uptask of bothtest-noble-gcpandtest-resolute-gcpci/tasks/test-gcp.shmisc/tags.ymlto thenatsdeployment and passdeployment_tagsDependencies
cloudfoundry/bosh-bootloader#694—BBL_GCP_LABELS/--gcp-label, which makesbbllabel the director VM, jumpbox VM and the terraform resources it manages.Note: this pipeline runs the
bblbundled in thecloudfoundry/cf-deployment-concourse-tasksimage, so the labels only appear once that image ships abblrelease containing #694. Until then the env var is simply ignored.cloudfoundry/bosh-deployment#534—misc/tags.yml. Merge Add generic tags ops file #534 first, otherwise-o misc/tags.ymlfails.Verification
ci/pipeline.ymland the task YAML parse cleanly (python3 -c "yaml.safe_load(...)")bash -nclean ontest-gcp.shandbbl-up-bosh-gcp.shbosh interpolate ci/assets/nats.yml -o tests/cred-test.yml -o misc/tags.yml -v stemcell_os=ubuntu-noble -v 'deployment_tags={"pipeline":"bosh-deployment"}'→tags: {pipeline: bosh-deployment}presentNotes
The GCP jobs destroy the environment in an
ensure: bbl-down, so this pipeline is not long-lived. It validates the mechanism end-to-end before rolling out to persistent environments.