Validate registered identifiers - #199
Merged
Merged
Conversation
marmeladema
force-pushed
the
validate-identifier-registration
branch
4 times, most recently
from
September 10, 2026 15:04
b61c8b0 to
d0950d3
Compare
utkarshgupta137
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate field and function identifiers during scheme registration.
Identifiers must:
_or an ASCII letter.This prevents integers and IP addresses such as
123and192.0.2.1from being registered as identifiers while preserving existing fields such ascf.response.1xxx_code.Registration now returns a structured
IdentifierRegistrationError, distinguishing invalid identifiers from redefinitions. Parsing and registration share identifier tokenization, ensuring every accepted registration remains parseable.Raw byte strings such as
a.b.c.dremain ambiguous because they also match identifier syntax. Resolving that ambiguity is outside this PR’s scope.