fix: upload body completion tracking - #44
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes upload completion tracking in CountingBody by replacing a size_hint()-based “last frame” heuristic (which fails for bodies without bounded size hints, like UploadBody) with is_end_stream() checks on the wrapped body, ensuring completion events are emitted exactly once.
Changes:
- Switch “last frame” detection from
size_hint()to the wrapped body’sis_end_stream()state. - Ensure final
ByteCount+Finishedevents are guarded bysent_finishedin both the last-frame path and thePoll::Ready(None)path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HenriqueSFernandes
requested review from
andre-j3sus,
carlosefr and
devandrepascoa
July 17, 2026 10:42
carlosefr
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CountingBodyrelied onsize_hint()to detect the final upload frame, butUploadBodydoes not provide a bounded size hint.Use the wrapped body’s
is_end_stream()state and guard final events so completion is reported exactly once.Closes #42