Skip to content

fix: file export follow-ups - #256

Merged
maxwellpeterson merged 1 commit into
mainfrom
mpeterson/fix-browser-export-readiness
Aug 18, 2026
Merged

fix: file export follow-ups#256
maxwellpeterson merged 1 commit into
mainfrom
mpeterson/fix-browser-export-readiness

Conversation

@maxwellpeterson

@maxwellpeterson maxwellpeterson commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Validating #197 before release turned up a few issues, which this PR fixes:

  • exportGadget incorrectly used .move() instead of .dup()
  • restore 250ms DOM settlement window to avoid breaking PDF export for existing gadgets that don't implement top-level await
    • new gadgets should use top-level await by default, but existing gadgets rely on DOM settlement logic for PDF export

@github-actions github-actions Bot added the kernel Changes to the Workshop kernel label Aug 18, 2026
@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Invalid Anthropic API Key

github run

@maxwellpeterson maxwellpeterson changed the title file export follow-up fixes from #197 fix: file export follow-ups Aug 18, 2026
@ask-bonk

ask-bonk Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

@maxwellpeterson Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Preview: pr256-mpeterson-fix-e32bc513

https://pr256-mpeterson-fix-e32bc513-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@maxwellpeterson
maxwellpeterson marked this pull request as ready for review August 18, 2026 17:55
maxwellpeterson
maxwellpeterson commented Aug 18, 2026
View reviewed changes
Comment thread packages/workshop-backend/browser/browser-export-page.ts
@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/fix-browser-export-readiness branch from 9b89c97 to 7e550ae Compare August 18, 2026 18:14
@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Incorrect API key provided: sqh4532y****************************xNoA. You can find your API key at https://platform.openai.com/account/api-keys.

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Incorrect API key provided: sqh4532y****************************xNoA. You can find your API key at https://platform.openai.com/account/api-keys.

github run

@ask-bonk

ask-bonk Bot commented Aug 18, 2026

Copy link
Copy Markdown

APIError: Incorrect API key provided: sqh4532y****************************xNoA. You can find your API key at https://platform.openai.com/account/api-keys.

github run

@maxwellpeterson

maxwellpeterson commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

bonk break glass

@github-actions github-actions Bot added the bonk-break-glass Skip automatic Bonk PR review label Aug 18, 2026
@maxwellpeterson
file export follow-up fixes from #197
8150945 
- exportGadget incorrectly used .move() instead of .dup()
- restore 250ms DOM settle window to avoid breaking PDF export for
  existing gadgets that don't implement top-level await
@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/fix-browser-export-readiness branch from 7e550ae to 8150945 Compare August 18, 2026 18:26
@maxwellpeterson
maxwellpeterson merged commit 01a96b4 into main Aug 18, 2026
13 checks passed
@maxwellpeterson
maxwellpeterson deleted the mpeterson/fix-browser-export-readiness branch August 18, 2026 18:29
@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Open
darjss pushed a commit to darjss/cloudflare-os-erxes that referenced this pull request Aug 26, 2026
@maxwellpeterson
file export follow-up fixes from cloudflare#197 (cloudflare#256)
04c7e26 
- exportGadget incorrectly used .move() instead of .dup()
- restore 250ms DOM settle window to avoid breaking PDF export for
  existing gadgets that don't implement top-level await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndisidore ndisidore ndisidore approved these changes

Assignees

No one assigned

Labels

bonk-break-glass Skip automatic Bonk PR review kernel Changes to the Workshop kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxwellpeterson @ndisidore