Skip to content

[Access] Document managed OAuth for MCP apps#31736

Open
kennyj42 wants to merge 1 commit into
cloudflare:productionfrom
kennyj42:kjohnson/mcp-managed-oauth-docs-2
Open

[Access] Document managed OAuth for MCP apps#31736
kennyj42 wants to merge 1 commit into
cloudflare:productionfrom
kennyj42:kjohnson/mcp-managed-oauth-docs-2

Conversation

@kennyj42

Copy link
Copy Markdown
Collaborator

Summary

  • Update Secure MCP servers to use the Access MCP server app type for the recommended managed OAuth flow.
  • Add MCP server applications to the Managed OAuth page.
  • Clarify that portal managed OAuth is separate from upstream MCP server OAuth.

Validation

  • pnpm run check
  • pnpm run format:core:check
  • git diff --check
  • CRLF check on changed files

@mvvmm

mvvmm commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/full-review

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review

💡 2 suggestions found in full PR diff.

Fan Out Code Review

This code review is in beta and may not always be helpful — use your judgment.

✅ No code review issues found.

Style Guide Review

Suggestions (2)
File Issue
cloudflare-one/access-controls/ai-controls/secure-mcp-servers.mdx line 128 CURL component for Cloudflare API endpoint<CURL> documents https://api.cloudflare.com/client/v4/accounts/{account_id}/access/apps Fix: Use <APIRequest> instead of <CURL> for Cloudflare API endpoints.
cloudflare-one/access-controls/applications/http-apps/managed-oauth.mdx line 69 Use sentence case for headings — Heading uses title case: ## Enable managed OAuth on an MCP server application Fix: Use sentence case: ## Enable managed OAuth on an MCP server application → consider ## Enable managed OAuth on an MCP server application with only Enable, OAuth, and MCP capitalized.
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/fan-out-review Forces a full review using the per-file fan-out mode regardless of diff size. Each file is reviewed in its own session for maximum per-file detail. ⚠️ This may take a very long time on large PRs and may fail or time out — use only when you want the most thorough review and are willing to wait.
/holistic-review Forces a full review using the holistic mode regardless of diff size. The entire diff is reviewed in one pass, enabling cross-file reasoning. Faster and more reliable on large PRs.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.

mvvmm added a commit that referenced this pull request Jun 26, 2026
…lize

A specialist DO that is hard-evicted mid-review never reaches the
writeStreamResult call at the end, leaving no code.json/style.json for
the other specialist to detect and claim the finalize lock — exactly
the stuck-review scenario seen on PR #31736.

Fix: each specialist now writes { ok: false, degradedResult } to R2
BEFORE starting its review. If the DO is evicted, the placeholder is
already there. The placeholder is overwritten with the real result on
success. Either way finalize always has two stream results and will run,
posting a degraded-section comment rather than staying stuck forever.

Also fixes the unused FinalizeContext import lint error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants