[Secrets Store] Clarify role, API token, and scope permissions#31724
Open
mitch292 wants to merge 1 commit into
Open
[Secrets Store] Clarify role, API token, and scope permissions#31724mitch292 wants to merge 1 commit into
mitch292 wants to merge 1 commit into
Conversation
- Describe the two independent enforcement checks (authorization and secret scope) and that both must pass for actions like deploying a Worker with a Secrets Store binding. Authorization for a given request comes from either a user role (dashboard) or an API token permission, not both. - Clarify that Account Secrets Store Read only allows viewing metadata, and that Account Secrets Store Edit is required to bind a secret to another Cloudflare resource (Workers, AI Gateway). - Add a CI/CD caution callout reproducing the error message users hit when their wrangler-action token only has Read permission (cloudflare/workers-sdk#8964). - Add a Secret scopes section documenting the workers and ai-gateway scopes and how to set them via dashboard, API, or Wrangler.
Contributor
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. ❌ This review could not complete this run; results may be incomplete. It will retry on the next push. Style Guide ReviewWarnings (1)
Suggestions (3)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to clarify the proper API token permissions required for deploying a secret and the additional level of per service authorization required on the secret scopes.
Screenshots (optional)
Overview change

API Token permission clarifications

Secret scope clarifications

Documentation checklist