ci(cla): report dispatched CLA pass via commit status#206
Open
teamchong wants to merge 1 commit into
Open
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#204 wasn't enough. When
cla.ymlruns viaworkflow_dispatch, the run's check suite lands on the commit withassociated_prs=0, so it never attaches to the release PR. The run goes green but the merge box never sees aCLAssistantcheck and the PR stays blocked on the required status check.This keeps everything from #204 (trigger, validation guard, dispatch from release.yml) and only changes how the result is reported. After the guard passes, the workflow posts a commit status with context
CLAssistanton$GITHUB_SHA. Statuses attach to the SHA directly, so they show up in the PR status rollup and satisfy the required check even with the ruleset pinned to the GitHub Actions app. No new permissions, the workflow already hadstatuses: write.Tested end to end on my fork instead of experimenting here. Mirrored the ruleset (required status check
CLAssistantpinned to the GitHub Actions app) and had a throwaway workflow open a fake release PR shaped like a real one, opened by github-actions[bot] fromchangeset-release/mainwith a bot-authored head commit so it passes the guard: teamchong#2. Before the fix it sat atmergeStateStatus: BLOCKEDwith an empty rollup, same as the incident here. Then I dispatched it the same way release.yml does (gh workflow run cla.yml --ref changeset-release/main -f pull_request=2, run: https://github.com/teamchong/capnweb/actions/runs/28710748911) and it flipped tomergeable: truewithCLAssistant: successin the rollup.