Add workflow idempotency keys so active runs deduplicate - #1998
Draft
ericclemmons wants to merge 1 commit into
Draft
Add workflow idempotency keys so active runs deduplicate#1998ericclemmons wants to merge 1 commit into
ericclemmons wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 28c4354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr – Add active-lifetime
idempotencyKeysupport torunWorkflow()so concurrent callers reuse one Workflow instance.Agents currently persist Workflow tracking only after
workflow.create()returns. Concurrent callers can therefore both create instances before either tracking row exists, and callers that compensate withblockConcurrencyWhile()hold a Durable Object lock across external I/O.This change atomically claims
(workflow_name, idempotency_key)in Agent SQLite before the Workflow RPC. Calls with an occupied key return the active Workflow ID. Terminal tracking rows remain retained, while their key becomes available for a new Workflow instance.The proposed RFC keeps
queue,cancel, andreplaceconcurrency policies out of this initial primitive because they require durable payload storage and lifecycle orchestration.References: Durable Objects concurrency guidance