fix(argocd): revert DSO chart versions to env vars - #2394
Merged
Conversation
3 tasks
shikanime
force-pushed
the
shikanime/push-tpltzqtsrxyu
branch
from
July 30, 2026 10:48
47617af to
fc5d239
Compare
shikanime
changed the title
shikanime
force-pushed
the
shikanime/push-tpltzqtsrxyu
branch
from
July 30, 2026 11:03
fc5d239 to
aad7c8f
Compare
KepoParis
reviewed
Jul 30, 2026
KepoParis
approved these changes
Jul 30, 2026
shikanime
enabled auto-merge
July 30, 2026 14:11
shikanime
force-pushed
the
shikanime/push-tpltzqtsrxyu
branch
3 times, most recently
from
July 30, 2026 14:54
1a58e33 to
63b065a
Compare
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Id507e32defd22c91e7008e26734863ca6a6a6964
shikanime
force-pushed
the
shikanime/push-tpltzqtsrxyu
branch
from
July 30, 2026 15:11
63b065a to
38dc31c
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (26.30% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Fixes #2393
Quel est le comportement actuel ?
Les versions de chart DSO (
DSO_ENV_CHART_VERSION,DSO_NS_CHART_VERSION) étaient lues depuis la configuration plugin (config.argocd?.dsoEnvChartVersion) au lieu d'être lues depuis les variables d'environnement viaprocess.env.Quel est le nouveau comportement ?
Les versions de chart DSO sont à nouveau lues depuis les variables d'environnement (
process.env.DSO_ENV_CHART_VERSION/process.env.DSO_NS_CHART_VERSION) avec des valeurs par défaut en dur dansconfiguration.service.ts.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Revert du commit
chore: upstream static env var to infosqui avait introduit la régression.