feat(deployment): add DeploymentValueSource model - #2369
Merged
Conversation
13 tasks
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/deployment-value-sources
branch
from
July 27, 2026 09:25
38ee1fc to
9e6d08e
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/deployment-value-sources
branch
from
July 27, 2026 10:19
9e6d08e to
52edb1d
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
previously approved these changes
Jul 27, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
J'aime beaucoup les changes qui découplent les changements de BDD à l'utilisation des changements de BDD ✅
KepoParis
force-pushed
the
feat/deployment-value-sources
branch
from
July 28, 2026 10:06
52edb1d to
87d2da6
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources
branch
from
July 28, 2026 10:09
87d2da6 to
79c3918
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (26.20% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2247
Quel est le comportement actuel ?
Une source de déploiement (
DeploymentSource) ne permet pas de déclarer desources de valeurs (value sources) supplémentaires — internes ou externes —
pour surcharger les valeurs du chart.
Quel est le nouveau comportement ?
DeploymentSource:DeploymentInternalValueSource(relation « many ») :order+path,pour référencer des fichiers de valeurs internes à la source de déploiement.
DeploymentExternalValueSource(relation optionnelle « one », contrainted'unicité sur
deploymentSourceId) :order,path,ref,targetRevisionet unrepositoryIdobligatoire (relation versRepository), pour référencer des valeurs externes.DeploymentSourceparent (et l'externe également avec son
Repository).Repositoryexpose désormaisdeploymentExternalValueSources.server-nestjset
server(legacy).test-utils) complétés avec les nouvellescollections
deploymentInternalValueSource/deploymentExternalValueSource.Cette PR introduit-elle un breaking change ?
Non. Ajout de nouvelles tables uniquement, aucune modification destructive du
schéma existant.
Autres informations
Ce changement s'adapte au nouveau helm-chart
(https://github.com/cloud-pi-native/helm-charts) afin de pouvoir ajouter des
valeurs externes (external values) au chart
dso-env.Cette PR ne couvre que la partie backend (schéma / migration). L'exploitation
par l'API (service, contrôleur, schéma partagé) fait l'objet de la PR #2372
(empilée sur celle-ci) ; les composants client suivront.