fix(ci): merge digests after both arch image builds - #2366
Closed
shikanime wants to merge 6 commits into
Closed
Conversation
shikanime
force-pushed
the
fix/merge-digest-cross-arch-nginx-strangler-2364
branch
from
July 27, 2026 07:26
1c8bf48 to
85e0302
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
shikanime
marked this pull request as draft
July 27, 2026 08:47
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (26.20% Estimated after merge)
shikanime
commented
Jul 27, 2026
shikanime
left a comment
shikanime
left a comment
Member
Author
There was a problem hiding this comment.
Review: #2366 — fix(ci): merge digests after both arch image builds
Verdict: APPROVE (compliance review — GitHub blocks self-approval)
Scope
job-build.yml: +1 descriptive line onPR_NUMBERinput (docs only).workflow-create-or-update-release.yml: addsbuild-arm64to aneedschain so the downstream digest-merge / chart-update step waits for both amd64 and arm64 builds.
Compliance checklist
- Change matches PR title/intent (ordering fix, not logic change)
-
build-arm64job already exists; only missing from thisneedslist - No behavioral risk: pure CI dependency ordering; no secret/env exposure
- Conventional commit / title style OK
- No test needed (workflow YAML)
No blocking issues. Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#2364
Problem
The release workflow currently lets each per-architecture build job push its own digest/merge path independently. That can leave separate arch-specific manifests in GHCR and inconsistent image state after release builds.
Fix
Keep the existing
build-amd64andbuild-arm64splits, but add one finalmerge-manifestsjob that waits for both builds, downloads all pushed digests together, and runsdocker buildx imagetools createonce to produce a single merged manifest list with the expected release tags.Notes
job-build.ymlgets a new optionalSKIP_MERGEinput; per-arch builds set it totrue.