Improve performance of clojure-ts-align#145
Open
rrudakov wants to merge 1 commit into
Open
Conversation
Cache semantic indentation rules for a single clojure-ts-align run to avoid lookup for every repeating symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache semantic indentation rules for a single
clojure-ts-alignrun to avoid lookup for every repeating symbol.Context: I noticed that
clojure-ts-aligncan be quite slow when aligning very large expressions (i.e. large EDN system configurations or large integration test functions).clojure-ts-modeperforms lookup for an indentation rule for every symbol, with CIDER connected it also involves nREPL communication.I've been using this improved version for a very long time and haven't noticed any downsides.
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!