commitlog: Don't lock while compressing#4981
Merged
joshua-spacetime merged 2 commits intoMay 9, 2026
Merged
Conversation
Commitlog compression is coordinated externally, and it is safe to compress the same segment concurrently. Therefore, we can release the lock before starting the actual compression work, thereby avoiding to interfere with writes. Also, just ignore the currently active segment instead of panicking.
kim
force-pushed
the
kim/commitlog/dont-lock-while-compressing
branch
from
dd087f0 to
9f401b5
Compare
joshua-spacetime
approved these changes
May 8, 2026
zvervospacetimedb
pushed a commit
to zvervospacetimedb/SpacetimeDB
that referenced
this pull request
May 11, 2026
# Description of Changes This reverts commit ca1b45f since after clockworklabs#4981 we no longer hold the lock while compressing. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commitlog compression is coordinated externally, and it is safe to compress the same segment concurrently. Therefore, we can release the lock before starting the actual compression work, thereby avoiding to interfere with writes.
Also, return an error if the mutable segment is requested to be compressed, instead of panicking.