Repository navigation
Make ssh tests behavioural with a shared fake ssh - #311
Merged
Merged
Conversation
williammartin
requested review from
tidy-dev
and
a balanced review from Copilot
and removed request for
a team and
tidy-dev
October 8, 2026 14:24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test refactor and shared fake SSH utility are coherent, portable, and cover the intended behaviors without production changes.
0 open findings
What changed in this PR
Reworks SSH translation tests around observable behavior and adds a reusable fake SSH executable.
Changes:
- Adds behavioral coverage for translation, caching, and fallback behavior.
- Adds shared
StubSSHtest infrastructure.
| File | Description |
|---|---|
pkg/ssh/ssh_test.go |
Replaces implementation-focused tests with behavioral tests. |
internal/testutils/ssh_stub.go |
Provides configurable fake SSH test support. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
williammartin
force-pushed
the
williammartin-behavioural-ssh-tests
branch
from
October 8, 2026 15:17
d6dff30 to
3adbe01
Compare
williammartin
requested review from
babakks
and
a balanced review from Copilot
October 8, 2026 15:18
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The rewrite removes explicit coverage of SSH executable-path caching.
1 open finding
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| return c | ||
| }, | ||
| } | ||
| func TestTranslatorResolvesEachHostSeparately(t *testing.T) { |
babakks
approved these changes
Oct 8, 2026
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This rewrites the
pkg/sshtests to exercise behaviour throughssh.Translator.Translate. It addstestutils.StubSSHininternal/testutils. This puts a fakesshonPATH, built from the running test binary. Now each test describes what a caller sees.The test package's
TestMainneeds to callRunFakeSSHIfRequested. It only acts when the binary runs asssh. This is groundwork for adding comprehensivepkg/repositorytests in #274. No production code changes.