Skip to content

hotfix/cp-11871-android-scrollable-background-renders-gray#356

Merged
snuricp merged 1 commit into
masterfrom
hotfix/cp-11871-android-scrollable-background-renders-gray
Jun 11, 2026
Merged

hotfix/cp-11871-android-scrollable-background-renders-gray#356
snuricp merged 1 commit into
masterfrom
hotfix/cp-11871-android-scrollable-background-renders-gray

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixed an issue where, when non-blocking mode was enabled, a gray background was shown instead of the configured background color.


Note

Low Risk
Single conditional UI background change in banner initialization with no auth, data, or API impact.

Overview
Fixes a gray backdrop on native (non-HTML) app banners when non-blocking mode is on.

In AppBannerPopup.init(), for non-HTML banners the code already applies the configured background via composeBackground on bannerBackGroundImage and body. The root parent constraint layout could still show a default/opaque fill outside the banner chrome. The PR sets parent to transparent when isNonBlockingAppBanners is true, matching the intent of non-blocking overlays so only the composed banner background is visible—not a gray full-area layer.

Reviewed by Cursor Bugbot for commit 91aa7bc. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Fixes CP-11871: On Android, non-blocking app banners no longer render a gray background; they now show the configured background color or image. We set the parent view background to transparent when non-blocking mode is enabled.

Written for commit 91aa7bc. Summary will update on new commits.

Review in cubic

Fixed an issue where, when non-blocking mode was enabled, a gray background was shown instead of the configured background color.
@unnaticleverpush unnaticleverpush self-assigned this Jun 10, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@unnaticleverpush unnaticleverpush requested a review from snuricp June 11, 2026 07:01
@snuricp snuricp merged commit b01c2a2 into master Jun 11, 2026
4 of 7 checks passed
@snuricp snuricp deleted the hotfix/cp-11871-android-scrollable-background-renders-gray branch June 11, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants