fix: use exact Super Launch badge snippet - #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Correct the merged Super Launch footer badge because Super Launch does not recognize the current embed and reports an image URL problem. Start from a freshly pulled
origin/main, use the supplied anchor and Next.js<Image>snippet withwidth="300"andheight="300", follow the PR workflow, and do not create a blog post.What changed
<Image>attributes: exact product URL, image URL, alt text, 300×300 intrinsic attributes,_blanktarget, andnoopenerrelationship.https://www.superlaun.ch/badge.pngwith no query string.The resulting component is the supplied markup, formatted by the repository:
Reasoning
The previous implementation adapted the vendor asset with custom dimensions and styling, but Super Launch did not recognize it. This fix follows the supplied Next.js embed contract. Next.js requires an explicit allowlist for a remote
<Image>, so the configuration permits only the required HTTPS badge asset.Blog post
Skipped per the original request. This is a focused compatibility correction to an existing footer badge.
Screenshots / preview evidence
Preview: https://xpenser-pr-082.cleverbrush.com
href,target,rel,alt,width="300", andheight="300"all match the supplied embed.https://www.superlaun.ch/badge.png; the image completed loading at its natural 384×106 ratio and renders at 300px wide without distortion.https://www.superlaun.ch/products/2933in a separate tab.Validation
Local
npm run lintnpm run typechecknpm test— 95 files, 520 tests passedGitHub / preview
Telemetry
ERROR/FATALlogs, andhttp.server.duration.countfor resource servicexpenser-web-pr-82over the last hour.Notification
127.0.0.1:8787refused the connection, so notification is explicitly skipped as unavailable.Validated against head SHA
40021de2808e75d82928754874fe82a0e954d0c6.