fix(express): forward all auth options to authenticateRequest#8370
Open
jacekradko wants to merge 7 commits intomainfrom
Open
fix(express): forward all auth options to authenticateRequest#8370jacekradko wants to merge 7 commits intomainfrom
jacekradko wants to merge 7 commits intomainfrom
Conversation
Spread the full options object through to clerkClient.authenticateRequest() instead of re-destructuring a hand-picked subset. This closes the class of bug where fields accepted by the ClerkMiddlewareOptions type (e.g. organizationSyncOptions, skipJwksCache, headerType) were silently ignored at runtime — same shape as the clockSkewInMs issue fixed in #8287. Middleware-only keys (clerkClient, debug, frontendApiProxy) are peeled off so they don't leak into the backend call.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 14375e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… are set The backend's createAuthenticateRequest factory pins apiUrl/apiVersion at client construction time and overrides any runtime values. The Express default ClerkClient singleton is built from env only, so passing apiUrl or apiVersion to clerkMiddleware() was silently ignored on the default path even after option-forwarding was generalized. When the caller hasn't supplied a custom clerkClient but did pass apiUrl or apiVersion, build a per-middleware ClerkClient with those values instead of using the singleton.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…verride Adds two regression tests: - The per-middleware ClerkClient actually routes outbound API traffic to the apiUrl override, not just that createClerkClient was called with it. Spies on global fetch and asserts the URL hits the override host. - The clerkMiddleware callback form (options as a function) also builds a per-middleware ClerkClient when the callback returns apiUrl.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wobsoriano
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8287. The middleware was forwarding only a hand-picked subset of options to authenticateRequest, so things like organizationSyncOptions, headerType, and skipJwksCache were typed but silently dropped. Now everything spreads through, minus the middleware-only keys.
apiUrl and apiVersion needed separate handling because @clerk/backend pins them at client construction time and the default Express client is built from env only. When they're set on the middleware and no custom clerkClient is supplied, we now build a per-middleware ClerkClient with those values.