Rename "Client Trust" to "Device Trust" in KDoc - #858
Merged
mwickett merged 1 commit intoAug 5, 2026
Conversation
Renames the customer-facing feature name in the four places it appears as prose in this SDK: the `NEEDS_CLIENT_TRUST` status KDoc and three KDoc comments on `SignInClientTrustView` / `ClientTrustWarningMessage`. These surface in IDE quick documentation and generated API docs. Identifiers are deliberately unchanged. The `com.clerk.ui.signin.clienttrust` package, `SignInClientTrustView`, `ClientTrustWarningMessage`, `isClientTrust`, `NEEDS_CLIENT_TRUST`, and the `needs_client_trust` wire value all keep their names, since the backing APIs are not being renamed and renaming them would break existing custom sign-in flows. The end-user-visible string (`signing_in_from_new_device`) already reads "You're signing in from a new device...", so no user-facing string changes. Part of PROT-875.
Contributor
📝 WalkthroughWalkthroughThe change updates sign-in documentation terminology from “client trust” to “device trust.” Enum values, serialized names, and runtime behavior remain unchanged. ChangesDevice trust terminology
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
manovotny
approved these changes
Aug 5, 2026
manovotny
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, but hopefully the mobile team can +1 too.
SarahSoutoul
approved these changes
Aug 5, 2026
mwickett
deleted the
mwickett/prot-875-rename-client-trust-to-device-trust
branch
August 5, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PROT-875.
What
Renames the customer-facing feature name "Client Trust" → "Device Trust" in the four places it appears as prose in this SDK:
SignIn.ktNEEDS_CLIENT_TRUSTstatus KDocSignInClientTrustView.kt@param factorline, and theClientTrustWarningMessageKDocThese surface in IDE quick documentation and generated API docs. "Client" is jargon to less technical readers, and "Device Trust" aligns with Protect's "Device Intelligence" naming. This SDK was flagged as still carrying the old name during review of the docs PR.
API values and identifiers are deliberately unchanged
Per Kyle in the naming thread: "we don't have to change APIs but the way we discuss clients externally should flip to devices."
So the
com.clerk.ui.signin.clienttrustpackage,SignInClientTrustView,ClientTrustWarningMessage,isClientTrust,NEEDS_CLIENT_TRUST, and theneeds_client_trustwire value all keep their names — renaming them would break existing custom sign-in flows. The diff is 4 lines and touches no identifier, sodetekt-baseline.xmlneeds no regeneration.No user-facing string changes
R.string.signing_in_from_new_devicealready reads "You're signing in from a new device. We're asking for verification to keep your account secure." — it was device-worded from the start, so nothing an end user sees changes here.Related
Note
Rename 'Client Trust' to 'Device Trust' in KDoc comments
Updates KDoc comments in
SignInandSignInClientTrustViewto replace 'client trust' with 'device trust', aligning in-code documentation with the product terminology change described in PROT-875. No runtime behavior is affected.🖇️ Linked Issues
Partially completes PROT-875, which tracks the full rename of 'Client Trust' to 'Device Trust' across docs and product to better align with 'Device Intelligence' feature naming.
Macroscope summarized 0a9bcd0.
Summary by CodeRabbit