feat(helpers): add managed AWS Config S3 notifications - #653
Draft
edersonbrilhante wants to merge 2 commits into
Draft
feat(helpers): add managed AWS Config S3 notifications#653edersonbrilhante wants to merge 2 commits into
edersonbrilhante wants to merge 2 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Automation gate testsResult: passed
Coverage: 85.22% (692/812 lines) Lowest-covered Lambda files
|
Contributor
OPA/conftest tenant-isolation gateResult: passed
|
Contributor
Offline IaC contract testsResult: passed
Coverage: 95.14% (1467/1542 lines) Lowest-covered Lambda files
|
Contributor
Mutation test critical Lambda boundariesResult: passed
Coverage: 39.67% (1215/3063 lines) Lowest-covered Lambda files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+21
| resource "aws_s3_bucket" "config_delivery" { | ||
| count = local.create_delivery_resources ? 1 : 0 | ||
|
|
||
| #checkov:skip=CKV_AWS_145:SSE-S3 is compatible with AWS Config delivery and avoids a KMS key dependency for the archive. | ||
| #checkov:skip=CKV_AWS_144:Each recorder writes to a regional bucket; cross-region replication is outside this module's archival contract. | ||
| #checkov:skip=CKV_AWS_18:CloudTrail provides control-plane audit records; a separate access-log bucket is not part of this helper. | ||
| bucket = local.delivery_bucket_name | ||
| force_destroy = false | ||
| tags = local.all_security_tags | ||
| } |
Comment on lines
+12
to
+21
| resource "aws_s3_bucket" "config_delivery" { | ||
| count = local.create_delivery_resources ? 1 : 0 | ||
|
|
||
| #checkov:skip=CKV_AWS_145:SSE-S3 is compatible with AWS Config delivery and avoids a KMS key dependency for the archive. | ||
| #checkov:skip=CKV_AWS_144:Each recorder writes to a regional bucket; cross-region replication is outside this module's archival contract. | ||
| #checkov:skip=CKV_AWS_18:CloudTrail provides control-plane audit records; a separate access-log bucket is not part of this helper. | ||
| bucket = local.delivery_bucket_name | ||
| force_destroy = false | ||
| tags = local.all_security_tags | ||
| } |
Comment on lines
+12
to
+21
| resource "aws_s3_bucket" "config_delivery" { | ||
| count = local.create_delivery_resources ? 1 : 0 | ||
|
|
||
| #checkov:skip=CKV_AWS_145:SSE-S3 is compatible with AWS Config delivery and avoids a KMS key dependency for the archive. | ||
| #checkov:skip=CKV_AWS_144:Each recorder writes to a regional bucket; cross-region replication is outside this module's archival contract. | ||
| #checkov:skip=CKV_AWS_18:CloudTrail provides control-plane audit records; a separate access-log bucket is not part of this helper. | ||
| bucket = local.delivery_bucket_name | ||
| force_destroy = false | ||
| tags = local.all_security_tags | ||
| } |
Comment on lines
+23
to
+33
| resource "aws_s3_bucket_ownership_controls" "config_delivery" { | ||
| count = local.create_delivery_resources ? 1 : 0 | ||
|
|
||
| # AWS Config delivers objects with the bucket-owner-full-control ACL. | ||
| #checkov:skip=CKV2_AWS_65:BucketOwnerPreferred preserves the ACL required by the AWS Config delivery contract. | ||
| bucket = aws_s3_bucket.config_delivery[0].id | ||
|
|
||
| rule { | ||
| object_ownership = "BucketOwnerPreferred" | ||
| } | ||
| } |
Contributor
OpenTofu module tests (latest-stable)Result: passed OpenTofu version:
|
Contributor
OpenTofu module tests (minimum-supported)Result: passed OpenTofu version:
|
edersonbrilhante
force-pushed
the
feat/aws-config-notifications
branch
from
August 13, 2026 19:23
7486d14 to
5e77db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a managed regional delivery path to the AWS Config recording helper:
.json.gzobject notifications to an encrypted SQS queue with a dead-letter queues3-custom-logsinputdelivery_bucket_nameMigration
Apply
aws_config_recordingand confirm AWS Config delivery to its new managed regional bucket before applying the updatedstoragemodule. The storage update deletesaws_s3_bucket_policy.config_delivery; callers that keep using an external delivery bucket must establish equivalent delivery permissions outsidestoragefirst.This change does not delete the long-term bucket or its historical
AWSLogs/<account-id>/Config/objects. Retention, migration, and historical backfill remain separate operator decisions.Type of Change
Testing
tofu -chdir=modules/helpers/aws_config_recording test -no-color(6 passed)tofu -chdir=modules/helpers/storage test -no-color(3 passed)pytest -q tests/quality(27 passed)No live AWS or Splunk deployment was performed.