Use Gemini subscription OAuth accounts only - #29
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:M
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| accounts, err := client.List(ctx, "gemini") | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Suggestion: Commands that do not need an account, such as prism gemini --version, now perform a network-backed credential listing before the Gemini CLI is invoked. This makes local CLI metadata commands fail when Prism is unavailable or credentials are invalid; handle local-only CLI commands before listing accounts or only list accounts when an authenticated execution is required. [api mismatch]
Severity Level: Major ⚠️
- ⚠️ `prism gemini --version` requires `GET /credentials/gemini`.
- ❌ Gemini CLI version output fails when Prism is unavailable.
- ⚠️ Local metadata commands cannot run with invalid credentials.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** internal/cli/gemini.go
**Line:** 67:70
**Comment:**
*Api Mismatch: Commands that do not need an account, such as `prism gemini --version`, now perform a network-backed credential listing before the Gemini CLI is invoked. This makes local CLI metadata commands fail when Prism is unavailable or credentials are invalid; handle local-only CLI commands before listing accounts or only list accounts when an authenticated execution is required.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| } | ||
| account, err := rotateProviderAccount(provider, accounts) | ||
| return provider, account, err | ||
| return rotateProviderAccount("gemini", accounts) |
There was a problem hiding this comment.
Suggestion: Default execution now invokes the shared file-backed rotation routine for every Gemini launch. That routine performs an unlocked read, increment, and rename, so concurrent prism gemini processes can select the same account and overwrite each other's rotation state. Protect the rotation read-modify-write sequence with an inter-process lock or an atomic state update. [race condition]
Severity Level: Major ⚠️
- ⚠️ Concurrent Gemini launches can reuse one subscription account.
- ⚠️ `account-rotation.json` loses increments under contention.
- ⚠️ Intended account load balancing becomes less reliable.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** internal/cli/gemini.go
**Line:** 97:97
**Comment:**
*Race Condition: Default execution now invokes the shared file-backed rotation routine for every Gemini launch. That routine performs an unlocked read, increment, and rename, so concurrent `prism gemini` processes can select the same account and overwrite each other's rotation state. Protect the rotation read-modify-write sequence with an inter-process lock or an atomic state update.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
1 participant
User description
Make
prism geminiselect only Gemini/Code Assist OAuth accounts. AI Studio API-key accounts are no longer accepted or preferred, preventing usage-based charges.\n\nVerification:go test ./...,go vet ./....CodeAnt-AI Description
Restrict Gemini CLI access to subscription-backed Google accounts
What Changed
prism gemininow uses only Gemini or Code Assist OAuth subscription accounts.Impact
✅ Prevented usage-based Gemini charges✅ Safer Gemini account selection✅ Clearer subscription setup guidance💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.