Fix Gemini CLI gateway authentication - #27
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:S
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| func isAutomatedGeminiPrompt(args []string) bool { | ||
| for _, argument := range args { | ||
| if argument == "-p" || argument == "--prompt" || strings.HasPrefix(argument, "--prompt=") { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
Suggestion: The detector scans arguments after the -- separator, even though parseClaudeOptions preserves -- and all following values as passthrough arguments. A prompt or positional value after -- equal to --prompt, -p, or beginning with --prompt= will incorrectly enable GEMINI_CLI_TRUST_WORKSPACE=true, granting workspace trust when the user did not request automated prompt mode. Stop scanning once -- is encountered. [incorrect condition logic]
Severity Level: Critical 🚨
- ❌ Separator-delimited arguments can enable workspace trust.
- ⚠️ Interactive Gemini execution may skip workspace confirmation.
- ⚠️ Trust boundary depends on raw argument text.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** internal/cli/gemini.go
**Line:** 220:227
**Comment:**
*Incorrect Condition Logic: The detector scans arguments after the `--` separator, even though `parseClaudeOptions` preserves `--` and all following values as passthrough arguments. A prompt or positional value after `--` equal to `--prompt`, `-p`, or beginning with `--prompt=` will incorrectly enable `GEMINI_CLI_TRUST_WORKSPACE=true`, granting workspace trust when the user did not request automated prompt mode. Stop scanning once `--` is encountered.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| if trustWorkspace && strings.EqualFold(name, "GEMINI_CLI_TRUST_WORKSPACE") { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Suggestion: Interactive invocations retain any inherited GEMINI_CLI_TRUST_WORKSPACE value because the variable is filtered only when trustWorkspace is true. A user or parent process with this variable set to true can therefore enable workspace trust without an explicit non-interactive prompt, violating the intended security boundary. Always remove the inherited variable and append it only for automated prompts. [security]
Severity Level: Critical 🚨
- ❌ Interactive Gemini sessions can inherit workspace trust.
- ⚠️ Workspace security prompts may be bypassed through process environment.
- ⚠️ Interactive tool execution receives broader workspace permissions.Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** internal/cli/gemini.go
**Line:** 239:241
**Comment:**
*Security: Interactive invocations retain any inherited `GEMINI_CLI_TRUST_WORKSPACE` value because the variable is filtered only when `trustWorkspace` is true. A user or parent process with this variable set to `true` can therefore enable workspace trust without an explicit non-interactive prompt, violating the intended security boundary. Always remove the inherited variable and append it only for automated prompts.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix1 participant
User description
Closes #25
Marks the official Gemini CLI gateway as externally authenticated and trusts the workspace only for explicit non-interactive prompt delegation.
Verified with
go test ./...,go vet ./...,go build ./..., and the official Gemini CLI 0.56.0 reaching the Prism gateway.CodeAnt-AI Description
Fix Gemini CLI authentication through Prism gateways
What Changed
Impact
✅ Gemini CLI requests authenticate through Prism gateways✅ Fewer authentication prompts for automated Gemini prompts✅ Interactive workspace trust remains unchanged💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.