Skip to content

fix(bundler): make default maxFeePerGas floor chain-aware #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alicepoltora wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(bundler): make default maxFeePerGas floor chain-aware #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion lib/src/main/java/com/circle/modularwallets/core/apis/bundler/BundlerApiImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ internal object BundlerApiImpl : BundlerApi {
try {
if (partialUserOp.maxFeePerGas == null || partialUserOp.maxPriorityFeePerGas == null) {
if (estimateFeesPerGas == null) {
val defaultMaxFeePerGas = parseGwei("3")
val defaultMaxFeePerGas = defaultMaxFeePerGasFor(bundlerClient.chain.chainId)
val defaultMaxPriorityFeePerGas = parseGwei("1")
val two = BigInteger.valueOf(2)
val fees = publicApi.estimateFeesPerGas(
Expand Down Expand Up @@ -359,6 +359,22 @@ internal fun getUpdatedCalls(calls: Array<EncodeCallDataArg>): Array<EncodeCallD
}.toTypedArray()
return updatedCalls
}
/**
* Chain-aware default `maxFeePerGas` floor.
*
* L2 base fees are routinely well below 1 gwei; a hard 3 gwei floor inflates the
* worst-case spend (`gas x maxFeePerGas`) that Gas Station policies check by
* ~100-500x on those chains, rejecting otherwise-trivial UserOperations.
* Ethereum mainnet-class chains keep the conservative L1-tuned default.
*/
internal fun defaultMaxFeePerGasFor(chainId: Long): BigInteger = when (chainId) {
8453L, 84532L, // Base, Base Sepolia
42161L, 421614L, // Arbitrum One, Arbitrum Sepolia
10L, 11155420L, // Optimism, OP Sepolia
137L, 80002L, // Polygon, Polygon Amoy
-> parseGwei("0.05")
else -> parseGwei("3")
}
internal suspend fun <T> startPolling(
pollingInterval: Long,
retryCount: Int,
Expand Down