Skip to content

.github: Add pull request template - #203

Merged
joamaki merged 1 commit into
mainfrom
pr/joamaki/add-pr-template
Sep 17, 2026
Merged

.github: Add pull request template#203
joamaki merged 1 commit into
mainfrom
pr/joamaki/add-pr-template

Conversation

@joamaki

@joamaki joamaki commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Let's add a slightly modified Cilium's PR template here. I removed the release-note section but otherwise the same.

@joamaki
joamaki requested a review from a team as a code owner September 14, 2026 09:38
@joamaki
joamaki requested review from tommyp1ckles and removed request for a team September 14, 2026 09:38
@joamaki
.github: Add pull request template
760a7c1 
Import Cilium's PR template. Removed the release-note
section but otherwise the same.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki
joamaki force-pushed the pr/joamaki/add-pr-template branch from a8ddede to 760a7c1 Compare September 14, 2026 09:40
@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown 
$ make
go build ./...
go: downloading go.yaml.in/yaml/v3 v3.0.4
go: downloading github.com/cilium/hive v1.0.4
go: downloading golang.org/x/time v0.15.0
go: downloading github.com/spf13/cobra v1.10.2
go: downloading github.com/spf13/pflag v1.0.10
go: downloading github.com/cilium/stream v0.0.1
go: downloading github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de
go: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading go.uber.org/dig v1.17.1
go: downloading golang.org/x/term v0.16.0
go: downloading github.com/spf13/viper v1.18.2
go: downloading golang.org/x/sys v0.17.0
go: downloading golang.org/x/tools v0.17.0
go: downloading github.com/spf13/cast v1.6.0
go: downloading github.com/fsnotify/fsnotify v1.7.0
go: downloading github.com/sagikazarmark/slog-shim v0.1.0
go: downloading github.com/spf13/afero v1.11.0
go: downloading github.com/subosito/gotenv v1.6.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.7
go: downloading github.com/pelletier/go-toml/v2 v2.1.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading golang.org/x/text v0.14.0
STATEDB_VALIDATE=1 go test ./... -cover -vet=all -test.count 1
go: downloading github.com/stretchr/testify v1.11.1
go: downloading go.uber.org/goleak v1.3.0
go: downloading golang.org/x/exp v0.0.0-20240119083558-1b970713d09a
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
ok  	github.com/cilium/statedb	270.728s	coverage: 79.5% of statements
ok  	github.com/cilium/statedb/index	0.004s	coverage: 48.6% of statements
ok  	github.com/cilium/statedb/internal	0.010s	coverage: 45.2% of statements
ok  	github.com/cilium/statedb/lpm	3.219s	coverage: 76.1% of statements
ok  	github.com/cilium/statedb/part	81.042s	coverage: 86.7% of statements
ok  	github.com/cilium/statedb/reconciler	0.290s	coverage: 93.3% of statements
	github.com/cilium/statedb/reconciler/benchmark		coverage: 0.0% of statements
	github.com/cilium/statedb/reconciler/example		coverage: 0.0% of statements
go test -race ./... -test.count 1
ok  	github.com/cilium/statedb	32.436s
ok  	github.com/cilium/statedb/index	1.013s
ok  	github.com/cilium/statedb/internal	1.037s
ok  	github.com/cilium/statedb/lpm	2.215s
ok  	github.com/cilium/statedb/part	29.148s
ok  	github.com/cilium/statedb/reconciler	1.329s
?   	github.com/cilium/statedb/reconciler/benchmark	[no test files]
?   	github.com/cilium/statedb/reconciler/example	[no test files]
go test ./... -bench . -benchmem -test.run xxx
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb
cpu: INTEL(R) XEON(R) PLATINUM 8573C
BenchmarkDB_WriteTxn_1-4                      	 1000000	      1009 ns/op	    990778 objects/sec	     656 B/op	      13 allocs/op
BenchmarkDB_WriteTxn_10-4                     	 2725110	       445.2 ns/op	   2246338 objects/sec	     352 B/op	       6 allocs/op
BenchmarkDB_WriteTxn_100-4                    	 3268152	       375.9 ns/op	   2660346 objects/sec	     317 B/op	       5 allocs/op
BenchmarkDB_WriteTxn_1000-4                   	 2647892	       403.7 ns/op	   2476977 objects/sec	     318 B/op	       5 allocs/op
BenchmarkDB_WriteTxn_100_SecondaryIndex-4     	 2053362	       583.1 ns/op	   1715031 objects/sec	     419 B/op	       7 allocs/op
BenchmarkDB_WriteTxn_CommitOnly_100Tables-4   	 1320475	       907.5 ns/op	    1112 B/op	       4 allocs/op
BenchmarkDB_WriteTxn_CommitOnly_1Table-4      	 2222778	       539.7 ns/op	     224 B/op	       4 allocs/op
BenchmarkDB_NewWriteTxn-4                     	 2373108	       492.2 ns/op	     200 B/op	       3 allocs/op
BenchmarkDB_WriteTxnCommit100-4               	 1331722	       902.0 ns/op	    1096 B/op	       4 allocs/op
BenchmarkDB_NewReadTxn-4                      	985091348	         1.256 ns/op	       0 B/op	       0 allocs/op
BenchmarkDB_Modify-4                          	    2616	    451535 ns/op	   2214665 objects/sec	  342510 B/op	    6073 allocs/op
BenchmarkDB_GetInsert-4                       	    2432	    495926 ns/op	   2016432 objects/sec	  326504 B/op	    6073 allocs/op
BenchmarkDB_RandomInsert-4                    	    2846	    421766 ns/op	   2370984 objects/sec	  318501 B/op	    5073 allocs/op
BenchmarkDB_RandomReplace-4                   	    1564	    773299 ns/op	   1293161 objects/sec	  432316 B/op	    8089 allocs/op
BenchmarkDB_SequentialInsert-4                	    2916	    407307 ns/op	   2455149 objects/sec	  318501 B/op	    5073 allocs/op
BenchmarkDB_SequentialInsert_Prefix-4         	     642	   1815060 ns/op	    550946 objects/sec	 2794466 B/op	   41797 allocs/op
BenchmarkDB_Changes_Baseline-4                	    2485	    470493 ns/op	   2125432 objects/sec	  388269 B/op	    6164 allocs/op
BenchmarkDB_Changes-4                         	    1304	    908663 ns/op	   1100518 objects/sec	  604067 B/op	    9331 allocs/op
BenchmarkDB_RandomLookup-4                    	   37072	     32293 ns/op	  30966524 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_SequentialLookup-4                	   50916	     23258 ns/op	  42995179 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_Prefix_SecondaryIndex-4           	   10000	    107858 ns/op	   9271479 objects/sec	  124952 B/op	    1026 allocs/op
BenchmarkDB_FullIteration_All-4               	    1363	    869394 ns/op	 115022643 objects/sec	     104 B/op	       4 allocs/op
BenchmarkDB_FullIteration_Prefix-4            	    1468	    800991 ns/op	 124845404 objects/sec	     136 B/op	       5 allocs/op
BenchmarkDB_FullIteration_Get-4               	     447	   2663232 ns/op	  37548358 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_FullIteration_Get_Secondary-4     	     240	   5000742 ns/op	  19997033 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_FullIteration_ReadTxnGet-4        	     434	   2725563 ns/op	  36689672 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_PropagationDelay-4                	  986738	      1119 ns/op	         9.000 50th_µs	        11.00 90th_µs	        41.00 99th_µs	     807 B/op	      15 allocs/op
BenchmarkDB_WriteTxn_100_LPMIndex-4           	  704673	      1735 ns/op	    576306 objects/sec	    1574 B/op	      35 allocs/op
BenchmarkDB_WriteTxn_1_LPMIndex-4             	  166818	     11253 ns/op	     88867 objects/sec	   14180 B/op	      78 allocs/op
BenchmarkDB_LPMIndex_Get-4                    	     406	   2929105 ns/op	   3414013 objects/sec	       0 B/op	       0 allocs/op
BenchmarkWatchSet_4-4                         	 2930786	       402.8 ns/op	     296 B/op	       4 allocs/op
BenchmarkWatchSet_16-4                        	  864192	      1359 ns/op	    1096 B/op	       5 allocs/op
BenchmarkWatchSet_128-4                       	   95388	     12625 ns/op	    8904 B/op	       5 allocs/op
BenchmarkWatchSet_1024-4                      	    8834	    126609 ns/op	   73743 B/op	       5 allocs/op
PASS
ok  	github.com/cilium/statedb	43.324s
PASS
ok  	github.com/cilium/statedb/index	0.003s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/internal
cpu: INTEL(R) XEON(R) PLATINUM 8573C
Benchmark_SortableMutex-4   	 8016950	       149.6 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/cilium/statedb/internal	1.203s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/lpm
cpu: INTEL(R) XEON(R) PLATINUM 8573C
Benchmark_txn_insert/batchSize=1-4         	    2520	    472110 ns/op	   2118149 objects/sec	  822424 B/op	   13975 allocs/op
Benchmark_txn_insert/batchSize=10-4        	    4526	    271378 ns/op	   3684893 objects/sec	  369202 B/op	    6668 allocs/op
Benchmark_txn_insert/batchSize=100-4       	    4712	    253633 ns/op	   3942700 objects/sec	  329619 B/op	    6027 allocs/op
Benchmark_txn_delete/batchSize=1-4         	    1873	    630086 ns/op	   1587085 objects/sec	 1270475 B/op	   13976 allocs/op
Benchmark_txn_delete/batchSize=10-4        	    3924	    302759 ns/op	   3302962 objects/sec	  356419 B/op	    5769 allocs/op
Benchmark_txn_delete/batchSize=100-4       	    4423	    272642 ns/op	   3667818 objects/sec	  270754 B/op	    5038 allocs/op
Benchmark_LPM_Lookup-4                     	   10000	    106253 ns/op	   9411480 objects/sec	       0 B/op	       0 allocs/op
Benchmark_LPM_All-4                        	  160192	      7469 ns/op	 133878421 objects/sec	      32 B/op	       1 allocs/op
Benchmark_LPM_Prefix-4                     	  159840	      7475 ns/op	 133781396 objects/sec	      32 B/op	       1 allocs/op
Benchmark_LPM_LowerBound-4                 	  315172	      3827 ns/op	 130637306 objects/sec	     288 B/op	       2 allocs/op
PASS
ok  	github.com/cilium/statedb/lpm	11.860s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/part
cpu: INTEL(R) XEON(R) PLATINUM 8573C
Benchmark_Set_Singleton_Create-4              	34777038	        33.26 ns/op	      24 B/op	       1 allocs/op
Benchmark_Set_Singleton_Has-4                 	133661634	         9.008 ns/op	       0 B/op	       0 allocs/op
Benchmark_StringMap_Txn_Insert-4              	   10000	    107439 ns/op	   9307593 items/sec	   98250 B/op	    1306 allocs/op
Benchmark_Uint64Map_Random-4                  	    2238	    534591 ns/op	   1870590 items/sec	 1323155 B/op	    6045 allocs/op
Benchmark_Uint64Map_Sequential-4              	    2228	    538008 ns/op	   1858708 items/sec	 1703090 B/op	    5753 allocs/op
Benchmark_Uint64Map_Sequential_Insert-4       	    2278	    508217 ns/op	   1967664 items/sec	 1695087 B/op	    4752 allocs/op
Benchmark_Uint64Map_Sequential_Txn_Insert-4   	   12999	     92060 ns/op	  10862483 items/sec	   90464 B/op	    2031 allocs/op
Benchmark_Uint64Map_Random_Insert-4           	    2386	    521611 ns/op	   1917137 items/sec	 1313704 B/op	    5039 allocs/op
Benchmark_Uint64Map_Random_Txn_Insert-4       	    7831	    148112 ns/op	   6751630 items/sec	  117967 B/op	    2409 allocs/op
Benchmark_Insert_RootOnlyWatch-4              	   13306	     90272 ns/op	  11077612 objects/sec	   75552 B/op	    2036 allocs/op
Benchmark_Insert-4                            	   13520	     88632 ns/op	  11282631 objects/sec	   76096 B/op	    2047 allocs/op
Benchmark_WatchReplace-4                      	   14635	     81950 ns/op	  12202506 objects/sec	   57305 B/op	    1006 allocs/op
Benchmark_Modify-4                            	   15556	     77017 ns/op	  12984129 objects/sec	   58056 B/op	    1007 allocs/op
Benchmark_GetInsert-4                         	   12686	     94572 ns/op	  10573990 objects/sec	   58056 B/op	    1007 allocs/op
Benchmark_Replace-4                           	36491089	        31.44 ns/op	  31804538 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Replace_RootOnlyWatch-4             	38488826	        31.92 ns/op	  31323818 objects/sec	       0 B/op	       0 allocs/op
Benchmark_txn_1-4                             	10576894	       112.4 ns/op	   8897051 objects/sec	      64 B/op	       3 allocs/op
Benchmark_txn_10-4                            	13345788	        89.31 ns/op	  11197240 objects/sec	      76 B/op	       2 allocs/op
Benchmark_txn_100-4                           	14545123	        80.17 ns/op	  12473988 objects/sec	      67 B/op	       2 allocs/op
Benchmark_txn_1000-4                          	12900297	        93.02 ns/op	  10750300 objects/sec	      65 B/op	       2 allocs/op
Benchmark_txn_delete_1-4                      	 5820412	       209.8 ns/op	   4766079 objects/sec	     632 B/op	       3 allocs/op
Benchmark_txn_delete_10-4                     	13832396	        85.94 ns/op	  11636063 objects/sec	     103 B/op	       1 allocs/op
Benchmark_txn_delete_100-4                    	16673736	        64.70 ns/op	  15455850 objects/sec	      35 B/op	       1 allocs/op
Benchmark_txn_delete_1000-4                   	18914260	        62.05 ns/op	  16116493 objects/sec	      28 B/op	       1 allocs/op
Benchmark_Get-4                               	   79050	     14967 ns/op	  66811597 objects/sec	       0 B/op	       0 allocs/op
Benchmark_GetWatch-4                          	   63866	     18807 ns/op	  53172350 objects/sec	       0 B/op	       0 allocs/op
Benchmark_All-4                               	  227504	      5239 ns/op	 190875861 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Iterator_All-4                      	  224538	      5378 ns/op	 185948351 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Iterator_Next-4                     	  227041	      5209 ns/op	 191986544 objects/sec	     896 B/op	       1 allocs/op
Benchmark_Hashmap_Insert-4                    	   24735	     48562 ns/op	  20592309 objects/sec	   74264 B/op	      20 allocs/op
Benchmark_Hashmap_Get_Uint64-4                	  233008	      5133 ns/op	 194830591 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Hashmap_Get_Bytes-4                 	  194889	      6128 ns/op	 163175627 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Delete_Random-4                     	      79	  13404151 ns/op	   7460375 objects/sec	 2539425 B/op	  102756 allocs/op
Benchmark_find16-4                            	279910509	         4.207 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex16-4                       	100000000	        11.47 ns/op	       0 B/op	       0 allocs/op
Benchmark_find64-4                            	399177944	         3.017 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex64_hit-4                   	394344451	         3.011 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex64_miss-4                  	379837616	         3.105 ns/op	       0 B/op	       0 allocs/op
Benchmark_find4-4                             	622688947	         1.893 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex4-4                        	360354549	         3.219 ns/op	       0 B/op	       0 allocs/op
BenchmarkSmallWriteTxn/updates_1-4            	  476455	      2332 ns/op	    3529 B/op	       4 allocs/op
BenchmarkSmallWriteTxn/updates_2-4            	  329475	      3297 ns/op	    4742 B/op	       6 allocs/op
BenchmarkSmallWriteTxn/updates_4-4            	  230761	      5176 ns/op	    7155 B/op	      11 allocs/op
BenchmarkSmallWriteTxn/updates_8-4            	  129680	      8957 ns/op	   11927 B/op	      20 allocs/op
BenchmarkSmallWriteTxn/updates_16-4           	   72188	     16534 ns/op	   21289 B/op	      38 allocs/op
BenchmarkAtomicWatchPointerFirstChannel-4     	25107286	        50.01 ns/op	     120 B/op	       2 allocs/op
BenchmarkAtomicWatchPointerChannel-4          	555640652	         2.089 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/cilium/statedb/part	56.871s
PASS
ok  	github.com/cilium/statedb/reconciler	0.004s
?   	github.com/cilium/statedb/reconciler/benchmark	[no test files]
?   	github.com/cilium/statedb/reconciler/example	[no test files]
go run ./reconciler/benchmark -quiet
1000000 objects reconciled in 1.44 seconds (batch size 1000)
Throughput 693181.89 objects per second
506MB total allocated, 5010182 in-use objects, 231MB bytes in use

@joamaki
joamaki merged commit 4c3d06c into main Sep 17, 2026
1 check passed
@joamaki
joamaki deleted the pr/joamaki/add-pr-template branch September 17, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-foundations

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joamaki