fix: handle indexes without string conversion - #202
Merged
Merged
Conversation
immanuwell
requested review from
tommyp1ckles
and removed request for
a team
September 13, 2026 16:06
Contributor
|
See my comment at #199 (review). The commit description and the AI influence level disclaimer is missing. I'll add a PR template soon to have a checklist... |
Indexes can omit FromString, but string-based queries through AnyTable call it unconditionally and panic. Return a query error for these indexes and cover the db/get path with a regression test. Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-query-without-from-string
branch
from
September 24, 2026 12:28
5175e0b to
776617d
Compare
Contributor
Author
|
@joamaki I am sorry, added both commit description and AIL (but I thought trivial |
Contributor
Author
|
@tommyp1ckles everything is addressed, please take a look |
joamaki
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexes can omit
FromString, butdb/getcalls it anyway and panicsRepro:
FromStringdb/get test 1Index.fromStringThe fix: return a clear query error instead
Tests:
makeAIL:1