Miscellaneous improvements to script test retrying commands - #82
Merged
Merged
Conversation
Commands that are retried may only eventually fail when the state context is canceled. However, at that point, the error that gets output is not informative, given that it references the context cancellation. Let's instead output the last error that triggered a retry, so that the cause of the failure is immediately visible. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Currently, the number of retries of retrying commands is only limited by the context; however, this can be limiting in certain circumstances, where one may want a context with a relatively long lifetime, and separately limit the number of retries. Hence, let's introduce the possibility of configuring a maximum number of retries; by default, no maximum is configured, and the previous behavior is preserved. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
joamaki
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR; add optional limit to retrying commands retries, and output last error upon retries failure. Please review commit by commit, and refer to the individual descriptions for additional details.