job: Avoid deadlock when adding jobs during stopping - #80
Merged
Merged
Conversation
The job registry held the registry mutex when stopping the jobs which can lead to a deadlock if a job tries to add a job during the stopping. Fix the issue by not holding the registry mutex when stopping the lifecycle. This wasn't required for anything except checking 'started'. The lifecycle had its own mutex and when it was stopping it only grabbed the mutex to collect jobs to stop so doesn't wait for a job to stop with mutex held. AIL:3 Signed-off-by: Jussi Maki <jussi.maki@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job registry held the registry mutex when stopping the jobs which can lead to a deadlock if a job tries to add a job during the stopping.
Fix the issue by not holding the registry mutex when stopping the lifecycle. This wasn't required for anything except checking 'started'. The lifecycle had its own mutex and when it was stopping it only grabbed the mutex to collect jobs to stop so doesn't wait for a job to stop with mutex held.
AIL:3