Skip to content

feat: [sc-19068] Support isolated gofer fire-drill sidecars - #328

Merged
devkoriel merged 5 commits into
mainfrom
sc-19068-support-fire-drill-sidecar
Jul 30, 2026
Merged

feat: [sc-19068] Support isolated gofer fire-drill sidecars#328
devkoriel merged 5 commits into
mainfrom
sc-19068-support-fire-drill-sidecar

Conversation

@devkoriel

@devkoriel devkoriel commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add optional extraContainers and extraVolumes to the gofer chart
  • add a nullable pod service-account automount override so staging fire-drill workloads can explicitly disable token mounting without changing existing releases
  • add a generic pod-extensions chart-testing fixture for the three new pod-spec controls
  • fix the existing proxy chart-testing fixture to use the real /healthz endpoint on the healthcheck port
  • bump the chart patch version to 0.4.4 and regenerate chart documentation

Safety

  • default automount behavior is unchanged because a null value omits the pod field
  • no workload or fire-drill scenario is deployed by this chart change
  • the generic fixture uses an inert, digest-pinned Kubernetes pause sidecar with non-root, read-only, capability-free settings and bounded resources
  • no fire-drill image, namespace, origin, alert, or scenario assertion is committed
  • the existing proxy fixture correction remains because standard ct install otherwise fails its liveness and readiness probes with HTTP 404

Local verification

  • helm lint charts/gofer
  • default helm template render
  • generic fixture renders token automount disabled plus an extra container and volume
  • Kubernetes 1.29 strict schema validation of the generic rendered fixture
  • proxy fixture renders /healthz on the healthcheck port for both probes
  • ct lint --config ct.yaml --charts charts/gofer
  • git diff --check
  • independent code review
  • GitHub ct install passes in the ephemeral kind cluster

Dependency

Required by the staging-only sc-19068 workload wiring; this chart PR does not deploy a workload.

@devkoriel devkoriel added the enhancement New feature or request label Jul 21, 2026
@devkoriel devkoriel self-assigned this Jul 21, 2026
@devkoriel
devkoriel requested a review from teghnet July 21, 2026 03:15
@devkoriel
devkoriel merged commit 9a89092 into main Jul 30, 2026
3 checks passed
@devkoriel
devkoriel deleted the sc-19068-support-fire-drill-sidecar branch July 30, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants