Don't fail repository fetch when remote is unreachable - #121
Open
justinleveck wants to merge 1 commit into
Open
Conversation
git fetch was not wrapped in its own error handling, so a dead remote, expired SSH key, or offline network took down the entire "fetch changes" request even though the local repo (which is all the analytics endpoints actually read) was perfectly fine. Catch the fetch failure specifically, skip the pull step when fetch didn't succeed, and fall back to reporting on local data with a fetchError message - the client already surfaces pullError the same way, so this is an additive, non-breaking response field.
justinleveck
force-pushed
the
fix/graceful-remote-fetch-failure
branch
from
August 7, 2026 02:53
185f063 to
1711ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git fetch --all --prunein the repository "fetch changes" route wasn't wrapped in its own error handling, so a dead remote, expired SSH key, or offline network took down the entire request with a 500, even though the local repo (which is all the analytics endpoints actually read) was perfectly fine.fetchErrormessage - additive, non-breaking response field, following the same pattern the client already uses forpullError.Test plan
tsc --noEmitclean onserver/formatWeekfailure insrc/git/__tests__/utils.test.tsis pre-existing/timezone-sensitive and reproduces identically on a cleanmaincheckout - unrelated to this change)