Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/dashboard.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The Dashboard is the main interface for monitoring and managing the system. It p
## Status Indicators
Four cards display real-time status:
- **Storage**: Shows drive connection status, used/total storage, and usage percentage.
- **Network File Sharing**: Summarizes `smbd`, `nmbd`, and `wsdd2`. The tile is operational when
- **SMB Network Shares**: Summarizes `smbd`, `nmbd`, and `wsdd2`. The tile is operational when
`smbd` is active and discovery services are either active or unavailable (not installed), partial
when `smbd` is active but at least one discovery service is inactive, and down
when `smbd` is not active.
Expand Down
2 changes: 1 addition & 1 deletion docs/drive_health.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ Manual recovery rules:
- Update only the SimpleSaferServer-managed `/etc/fstab` entry.
- Use `ntfs-3g` or `ntfs3` as the filesystem type for the managed backup-drive line.
- Run `sudo systemctl daemon-reload` after manually changing `/etc/fstab` so systemd forgets the old generated mount unit state.
- If the mount point changes, also check `/etc/samba/simple_safer_server_shares.conf` (see [Network File Sharing](network_file_sharing.md)).
- If the mount point changes, also check `/etc/samba/simple_safer_server_shares.conf` (see [SMB Network Shares](network_file_sharing.md)).
- Do not modify unrelated `/etc/fstab` entries.
- Back up `/etc/fstab` before editing it manually.

Expand Down
8 changes: 4 additions & 4 deletions docs/network_file_sharing.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Network File Sharing
# SMB Network Shares

The Network File Sharing page manages Samba shares and Samba service status.
The SMB Network Shares page manages Samba shares and Samba service status.
It also includes the server name. This is the name you'll use to find this
server on your network. Scheduled task alert emails include it in the subject.

Expand Down Expand Up @@ -175,7 +175,7 @@ If the share depends on unsupported Samba directives, leave it unmanaged and mai
3. Remove it from the unmanaged config source and add it to `/etc/samba/simple_safer_server_shares.conf`.
4. Keep only the supported share settings.
5. Restart Samba.
6. Reload the Network File Sharing page and confirm the share appears in the managed table.
6. Reload the SMB Network Shares page and confirm the share appears in the managed table.

### Example

Expand Down Expand Up @@ -209,7 +209,7 @@ Restarting Samba disconnects anyone who is currently connected to a share, so ac
sudo systemctl restart smbd nmbd wsdd2
```

Reload the Network File Sharing page after that.
Reload the SMB Network Shares page after that.

## Setup Wizard Behavior

Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ <h2 id="documentation" class="mb-3"><i class="fa-solid fa-book"></i> Documentati
<li><i class="fa-solid fa-cloud-arrow-up"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/cloud_backup.md" target="_blank">Cloud Backup</a></li>
<li><i class="fa-solid fa-download"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/system_updates.md" target="_blank">System Updates</a></li>
<li><i class="fa-solid fa-globe"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/ddns.md" target="_blank">Dynamic DNS</a></li>
<li><i class="fa-solid fa-network-wired"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/network_file_sharing.md" target="_blank">Network File Sharing</a></li>
<li><i class="fa-solid fa-network-wired"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/network_file_sharing.md" target="_blank">SMB Network Shares</a></li>
<li><i class="fa-solid fa-users"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/users.md" target="_blank">Users</a></li>
<li><i class="fa-solid fa-bell"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/alerts.md" target="_blank">Alerts</a></li>
<li><i class="fa-solid fa-list-check"></i> <a href="https://github.com/chrismin13/SimpleSaferServer/blob/main/docs/task_detail.md" target="_blank">Task Details</a></li>
Expand Down
2 changes: 1 addition & 1 deletion templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<i class="fas fa-house fa-fw"></i> Overview
</a>
<a href="{{ url_for('network_file_sharing') }}" class="nav-item {% if request.endpoint == 'network_file_sharing' %}active{% endif %}">
<i class="fas fa-share-nodes fa-fw"></i> File Sharing
<i class="fas fa-share-nodes fa-fw"></i> SMB Network Shares
</a>
<a href="{{ url_for('users_routes.users_page') }}" class="nav-item {% if request.endpoint == 'users_routes.users_page' %}active{% endif %}">
<i class="fas fa-users fa-fw"></i> Users
Expand Down
6 changes: 3 additions & 3 deletions templates/dashboard.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
<div class="status-tile-detail" id="backup-detail">—</div>
</div>

<!-- Network Sharing -->
<!-- SMB Network Shares -->
<div class="status-tile" id="sharing-tile">
<div class="status-tile-header">
<span class="status-tile-label"><i class="fas fa-share-nodes"></i> File Sharing</span>
<span class="status-tile-label"><i class="fas fa-share-nodes"></i> SMB Network Shares</span>
<span class="badge badge-neutral" id="sharing-status-badge">Checking…</span>
</div>
<div class="status-tile-value" id="sharing-status">—</div>
Expand Down Expand Up @@ -729,7 +729,7 @@ <h2 class="mb-4" style="font-size: var(--text-lg);">System Actions</h2>
badge.textContent = 'Partial';
val.textContent = 'Degraded';
// Keep the compact detail explicit so the dashboard matches the
// File Sharing page without adding another explanatory panel.
// SMB Network Shares page without adding another explanatory panel.
detail.textContent = `smbd: ${data.smbd}, nmbd: ${data.nmbd}, wsdd2: ${data.wsdd2}`;
} else {
badge.className = 'badge badge-danger';
Expand Down
4 changes: 2 additions & 2 deletions templates/network_file_sharing.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends "base.html" %}

{% block title %}{{ browser_title('File Sharing') }}{% endblock %}
{% block header %}Network File Sharing{% endblock %}
{% block title %}{{ browser_title('SMB Network Shares') }}{% endblock %}
{% block header %}SMB Network Shares{% endblock %}

{% block extra_css %}
{% endblock %}
Expand Down
3 changes: 3 additions & 0 deletions tests/test_app_factory_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def test_fake_dashboard_renders_storage_action_urls():
assert "Unavailable / Unavailable GB used" not in page
assert 'action="/unmount"' in page
assert 'action="/mount"' in page
assert "SMB Network Shares" in page
assert 'id="health-refresh-button"' in page
assert "<th>Next Run</th>" in page
assert "Disable Schedule" in page
Expand All @@ -81,6 +82,8 @@ def test_network_file_sharing_renders_three_service_status_labels_and_help_text(

assert response.status_code == 200
page = response.get_data(as_text=True)
assert "SMB Network Shares" in page
assert "Network File Sharing" not in page
assert "SMB Daemon (smbd)" in page
assert "NetBIOS Discovery (nmbd)" in page
assert "Windows Discovery (wsdd2)" in page
Expand Down
4 changes: 2 additions & 2 deletions tests/test_drive_health_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ def test_manual_recovery_references_sss_shares_file():

def test_manual_recovery_references_network_file_sharing_page():
section = _manual_recovery_section()
# Should point operators to the Network File Sharing docs page
assert "network_file_sharing" in section.lower() or "Network File Sharing" in section
# Should point operators to the SMB Network Shares docs page
assert "network_file_sharing" in section.lower() or "SMB Network Shares" in section


def test_manual_recovery_does_not_present_smb_conf_as_managed_share_config():
Expand Down
Loading